From patchwork Wed Oct 22 04:16:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 401885 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A4488140076 for ; Wed, 22 Oct 2014 15:20:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751013AbaJVETg (ORCPT ); Wed, 22 Oct 2014 00:19:36 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34932 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986AbaJVETe (ORCPT ); Wed, 22 Oct 2014 00:19:34 -0400 Received: by mail-pa0-f51.google.com with SMTP id lj1so2823109pab.24 for ; Tue, 21 Oct 2014 21:19:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dloZpUDjw42bmQ/Ji2z/zCwtmY5qw1X2zA1lceTjiGo=; b=jegF81kXbF5uWVgUYKBkI/JrR2MZVo758WAl9ezlGgPIj4NxjuoAs1MAdJyIVfsY3H NVclaOsIfRI9N9vNPyB488sKc3QRF+SCxnPBKOp0K2x5eKdxDyXxHo36upuZRFYlLID2 5wAv7g9tTroL4yyzdz/X9NQelrZzDmY16A/d4Vv3E2UbAfnKQmh6z/+8kkFftT4TqkOo ZECQ5MZkRn2GGU6P7Ol65DpE0pS4sjMotggt44xX6+O8q83vBZsOh5av91EKAWjHmvUp oIZd27Sao5HSuFpnupED2jVUZSlD7+UrBnygsvIvE+HiNnBwnwPFRbMCdqH0YEBJfiJr fdtQ== X-Received: by 10.67.29.177 with SMTP id jx17mr39517860pad.56.1413951573670; Tue, 21 Oct 2014 21:19:33 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id g3sm13254243pdh.33.2014.10.21.21.19.30 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Oct 2014 21:19:32 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: Varka Bhadram Subject: [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check Date: Wed, 22 Oct 2014 09:46:21 +0530 Message-Id: <1413951386-29645-2-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1413951386-29645-1-git-send-email-varkab@cdac.in> References: <1413951386-29645-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/wiznet/w5100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index 0f56b1c..bf195e3 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -638,8 +638,7 @@ static int w5100_hw_probe(struct platform_device *pdev) } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -ENXIO; + mem_size = resource_size(mem); priv->base = devm_ioremap_resource(&pdev->dev, mem);