From patchwork Tue Oct 21 14:51:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 401562 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AA02214001A for ; Wed, 22 Oct 2014 01:52:25 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780AbaJUOwF (ORCPT ); Tue, 21 Oct 2014 10:52:05 -0400 Received: from mail-lb0-f180.google.com ([209.85.217.180]:50835 "EHLO mail-lb0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755406AbaJUOwD (ORCPT ); Tue, 21 Oct 2014 10:52:03 -0400 Received: by mail-lb0-f180.google.com with SMTP id n15so1139258lbi.39 for ; Tue, 21 Oct 2014 07:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=sc5iOrq8950pxgHZrAB5NkfuxL22yr6rumiez6/z6pY=; b=DmOoJqrOpQQo3d6wgVkbEwLS8Jhaty2vAXDHjjNBpFxxGn6bS843xckrP8kXQ8vUs0 RoXxKMzeu02ch7PCIMOolTisxWhJr+BEZdxDQCdbHxIVGdIafBeegkYWxJZWEguheV3J uGd/yfZnnz6COOs8OHcxCtD6/o22yjUEzD1+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sc5iOrq8950pxgHZrAB5NkfuxL22yr6rumiez6/z6pY=; b=LNvixYVuWGWXvMwRnK2eO5ppxu6srVkEzQQAyAZ1WVTotyzRBLOirsP4QCNHqpRd2M 618sRYPTYoFFQdrqYtf2IC+d+UiXvVFkRV/Jo7io3ku8EN+HhpL0fhDwH51bVFPpdkTn vNcv+ocK9abPXQt7l2xBc/p5ddxIxtRejsZPuBppolX0pTKHQ4AWscOJ6bb+6dZEPV/l Jb+bm1uOd02aD7HQVQUDkw9ehFJ1hA71vSAX3gu62FFaH0c79o1+hEK/pSoZKk++NAmX O+/dwv/scxp6HX8tPQkBCISRyOANCrb/dZkx96o4aOO9Zupl0EGGjX0YqXmce5EtBWsM OROw== X-Gm-Message-State: ALoCoQmC6ZeS2prCWC8hEPYxNwlaAs1sov4N1W5oCq1Wqu726dsGXDNj7K7JRieu8axNc2zmxTh7 X-Received: by 10.112.173.100 with SMTP id bj4mr17378189lbc.78.1413903118937; Tue, 21 Oct 2014 07:51:58 -0700 (PDT) Received: from spencer.imf.au.dk ([130.225.20.51]) by mx.google.com with ESMTPSA id l7sm4552614lah.27.2014.10.21.07.51.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Oct 2014 07:51:58 -0700 (PDT) From: Rasmus Villemoes To: David Dillow Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Rasmus Villemoes Subject: [PATCH] net: typhoon: Remove redundant casts Date: Tue, 21 Oct 2014 16:51:43 +0200 Message-Id: <1413903103-3047-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Both image_data and typhoon_fw->data are const u8*, so the cast to u8* is unnecessary and confusing. Signed-off-by: Rasmus Villemoes Acked-by: David Dillow --- drivers/net/ethernet/3com/typhoon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/3com/typhoon.c b/drivers/net/ethernet/3com/typhoon.c index 48775b8..dede43f 100644 --- a/drivers/net/ethernet/3com/typhoon.c +++ b/drivers/net/ethernet/3com/typhoon.c @@ -1285,7 +1285,7 @@ typhoon_request_firmware(struct typhoon *tp) return err; } - image_data = (u8 *) typhoon_fw->data; + image_data = typhoon_fw->data; remaining = typhoon_fw->size; if (remaining < sizeof(struct typhoon_file_header)) goto invalid_fw; @@ -1343,7 +1343,7 @@ typhoon_download_firmware(struct typhoon *tp) int i; int err; - image_data = (u8 *) typhoon_fw->data; + image_data = typhoon_fw->data; fHdr = (struct typhoon_file_header *) image_data; /* Cannot just map the firmware image using pci_map_single() as