From patchwork Fri Oct 10 08:01:42 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Akshay Sarode X-Patchwork-Id: 398476 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9066F1400DE for ; Fri, 10 Oct 2014 19:02:25 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751601AbaJJICA (ORCPT ); Fri, 10 Oct 2014 04:02:00 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:47228 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbaJJIB7 (ORCPT ); Fri, 10 Oct 2014 04:01:59 -0400 Received: by mail-pa0-f49.google.com with SMTP id hz1so1252767pad.8 for ; Fri, 10 Oct 2014 01:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=TGqeG+50NDYqe1paSKs+xkbZun9YaV4PtGC7lhwuhF0=; b=ztAp6eKKc5NLzKfFNliNCVMYTBKfss+3PzqRQ5oXhNDnmW/8GEi3ID6mZ5HDTkdjjn PWAd7jJId3jolM7cbAj6bTGZ6oL5jyHTyY2PObAsT53LAB1Cb73M9hy1jHldGD+Vwu6X WzXJah07+xxImXREnTCL2LTmcDZmgFhebT2gjqPnQ9/CCNFQyBepsm/Bq0mhWmHlIOmL 9AhpVFj8wUN389arGuy7F2btXB+mjmon0Y/qEZrsAOD5AANSQraZ68mcm6XC9Ek/ILlR QiXGi5wjisWVHbX0PM6gaExFgCyM0KU2z/nJN+kINjlbftUj4tUawFO10kiTVL62AJCk JUFA== X-Received: by 10.70.88.197 with SMTP id bi5mr3501876pdb.80.1412928119180; Fri, 10 Oct 2014 01:01:59 -0700 (PDT) Received: from linux.akshay.com.akshay.com (triband-mum-120.61.85.9.mtnl.net.in. [120.61.85.9]) by mx.google.com with ESMTPSA id ip3sm2592723pbc.58.2014.10.10.01.01.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 10 Oct 2014 01:01:58 -0700 (PDT) From: Akshay Sarode To: John Stultz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Akshay Sarode Subject: [PATCH 1/1] Checkpatch: coding style errors in Nvidia ethernet driver Date: Fri, 10 Oct 2014 13:31:42 +0530 Message-Id: <1412928102-1696-1-git-send-email-akshaysarode21@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ERROR: "foo* bar" should be "foo *bar" ERROR: do not initialise statics to 0 or NULL CHECK: spinlock_t definition without comment Signed-off-by: Akshay Sarode --- drivers/net/ethernet/nvidia/forcedeth.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index f39cae6..dd03d1a 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -748,7 +748,7 @@ struct nv_skb_map { /* in dev: base, irq */ struct fe_priv { - spinlock_t lock; + spinlock_t lock; /* spinlock for SMA lock handling */ struct net_device *dev; struct napi_struct napi; @@ -893,6 +893,7 @@ enum { NV_MSI_INT_DISABLED, NV_MSI_INT_ENABLED }; + static int msi = NV_MSI_INT_ENABLED; /* @@ -902,6 +903,7 @@ enum { NV_MSIX_INT_DISABLED, NV_MSIX_INT_ENABLED }; + static int msix = NV_MSIX_INT_ENABLED; /* @@ -911,12 +913,18 @@ enum { NV_DMA_64BIT_DISABLED, NV_DMA_64BIT_ENABLED }; + static int dma_64bit = NV_DMA_64BIT_ENABLED; /* * Debug output control for tx_timeout */ -static bool debug_tx_timeout = false; +enum { + NV_DEBUG_TX_TIMEOUT_DISABLED, + NV_DEBUG_TX_TIMEOUT_ENABLED +}; + +static bool debug_tx_timeout = NV_DEBUG_TX_TIMEOUT_DISABLED; /* * Crossover Detection @@ -926,6 +934,7 @@ enum { NV_CROSSOVER_DETECTION_DISABLED, NV_CROSSOVER_DETECTION_ENABLED }; + static int phy_cross = NV_CROSSOVER_DETECTION_DISABLED; /* @@ -4562,7 +4571,8 @@ static int nv_nway_reset(struct net_device *dev) return ret; } -static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* ring) +static void nv_get_ringparam(struct net_device *dev, + struct ethtool_ringparam *ring) { struct fe_priv *np = netdev_priv(dev); @@ -4573,7 +4583,8 @@ static void nv_get_ringparam(struct net_device *dev, struct ethtool_ringparam* r ring->tx_pending = np->tx_ring_size; } -static int nv_set_ringparam(struct net_device *dev, struct ethtool_ringparam* ring) +static int nv_set_ringparam(struct net_device *dev, + struct ethtool_ringparam *ring) { struct fe_priv *np = netdev_priv(dev); u8 __iomem *base = get_hwbase(dev); @@ -4685,7 +4696,8 @@ exit: return -ENOMEM; } -static void nv_get_pauseparam(struct net_device *dev, struct ethtool_pauseparam* pause) +static void nv_get_pauseparam(struct net_device *dev, + struct ethtool_pauseparam *pause) { struct fe_priv *np = netdev_priv(dev); @@ -4694,7 +4706,8 @@ static void nv_get_pauseparam(struct net_device *dev, struct ethtool_pauseparam* pause->tx_pause = (np->pause_flags & NV_PAUSEFRAME_TX_ENABLE) != 0; } -static int nv_set_pauseparam(struct net_device *dev, struct ethtool_pauseparam* pause) +static int nv_set_pauseparam(struct net_device *dev, + struct ethtool_pauseparam *pause) { struct fe_priv *np = netdev_priv(dev); int adv, bmcr;