From patchwork Thu Sep 11 13:45:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Looijmans X-Patchwork-Id: 388246 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A73E614010C for ; Thu, 11 Sep 2014 23:46:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754784AbaIKNqJ (ORCPT ); Thu, 11 Sep 2014 09:46:09 -0400 Received: from atl4mhfb02.myregisteredsite.com ([209.17.115.56]:45840 "EHLO atl4mhfb02.myregisteredsite.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751742AbaIKNqI (ORCPT ); Thu, 11 Sep 2014 09:46:08 -0400 Received: from atl4mhob07.myregisteredsite.com (atl4mhob07.myregisteredsite.com [209.17.115.45]) by atl4mhfb02.myregisteredsite.com (8.14.4/8.14.4) with ESMTP id s8BDk7fG025932 for ; Thu, 11 Sep 2014 09:46:07 -0400 Received: from mailpod.hostingplatform.com ([10.30.71.209]) by atl4mhob07.myregisteredsite.com (8.14.4/8.14.4) with ESMTP id s8BDjs25028808 for ; Thu, 11 Sep 2014 09:45:54 -0400 Received: (qmail 7774 invoked by uid 0); 11 Sep 2014 13:45:54 -0000 X-TCPREMOTEIP: 88.159.208.100 X-Authenticated-UID: mike@milosoftware.com Received: from unknown (HELO paradigit.TOPIC.LOCAL) (mike@milosoftware.com@88.159.208.100) by 0 with ESMTPA; 11 Sep 2014 13:45:54 -0000 From: Mike Looijmans To: f.fainelli@gmail.com, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Mike Looijmans Subject: [PATCH] net/phy: micrel: Disable asymmetric pause for KSZ9031 Date: Thu, 11 Sep 2014 15:45:40 +0200 Message-Id: <1410443140-2833-1-git-send-email-mike.looijmans@topic.nl> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Our KSZ9031 appears to suffer from the same hardware bug as described for the KSZ9021 in commit 32fcafbcd1c9f6c7013016a22a5369b4acb93577, you have to unplug the cable and plug it back to get it to work. Remove the SUPPORTED_Asym_Pause flag for the KSZ9031 to fix this. Signed-off-by: Mike Looijmans Acked-by: Florian Fainelli --- drivers/net/phy/micrel.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index 5a8993b..a932a35 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -425,8 +425,7 @@ static struct phy_driver ksphy_driver[] = { .phy_id = PHY_ID_KSZ9031, .phy_id_mask = 0x00fffff0, .name = "Micrel KSZ9031 Gigabit PHY", - .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause - | SUPPORTED_Asym_Pause), + .features = (PHY_GBIT_FEATURES | SUPPORTED_Pause), .flags = PHY_HAS_MAGICANEG | PHY_HAS_INTERRUPT, .config_init = kszphy_config_init, .config_aneg = genphy_config_aneg,