From patchwork Tue Sep 9 20:15:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 387448 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 97F1A14018C for ; Wed, 10 Sep 2014 06:39:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741AbaIIUjf (ORCPT ); Tue, 9 Sep 2014 16:39:35 -0400 Received: from mail-bn1bbn0108.outbound.protection.outlook.com ([157.56.111.108]:56960 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752017AbaIIUj2 (ORCPT ); Tue, 9 Sep 2014 16:39:28 -0400 Received: from DM2PR03MB493.namprd03.prod.outlook.com (10.141.85.139) by DM2PR03MB365.namprd03.prod.outlook.com (10.141.55.12) with Microsoft SMTP Server (TLS) id 15.0.1024.12; Tue, 9 Sep 2014 20:39:26 +0000 Received: from CH1PR03CA012.namprd03.prod.outlook.com (10.255.156.157) by DM2PR03MB493.namprd03.prod.outlook.com (10.141.85.139) with Microsoft SMTP Server (TLS) id 15.0.1024.12; Tue, 9 Sep 2014 20:39:25 +0000 Received: from BN1AFFO11FD021.protection.gbl (10.255.156.132) by CH1PR03CA012.outlook.office365.com (10.255.156.157) with Microsoft SMTP Server (TLS) id 15.0.1024.12 via Frontend Transport; Tue, 9 Sep 2014 20:39:24 +0000 Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD021.mail.protection.outlook.com (10.58.52.81) with Microsoft SMTP Server (TLS) id 15.0.1019.14 via Frontend Transport; Tue, 9 Sep 2014 20:39:23 +0000 Received: from shlinux1.ap.freescale.net (shlinux1.ap.freescale.net [10.192.225.216]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id s89KdKeT002029; Tue, 9 Sep 2014 13:39:21 -0700 Received: by shlinux1.ap.freescale.net (Postfix, from userid 1013) id 554C61AE1F5; Wed, 10 Sep 2014 04:15:52 +0800 (CST) From: Frank Li To: , , , CC: , , , Fugang Duan , Frank Li Subject: [Patch v2 net-next 10/12] net: fec: init complete variable in early to avoid kernel dump Date: Wed, 10 Sep 2014 04:15:41 +0800 Message-ID: <1410293743-27874-11-git-send-email-Frank.Li@freescale.com> X-Mailer: git-send-email 1.7.8 In-Reply-To: <1410293743-27874-1-git-send-email-Frank.Li@freescale.com> References: <1410293743-27874-1-git-send-email-Frank.Li@freescale.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.168.50; CTRY:US; IPV:CAL; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019018)(6009001)(428002)(189002)(199003)(102836001)(89996001)(101416001)(77982001)(84676001)(87936001)(26826002)(88136002)(52956003)(83072002)(62966002)(104166001)(85852003)(50226001)(77156001)(85306004)(103686003)(4396001)(90102001)(21056001)(79102001)(87286001)(93916002)(575784001)(77096002)(76176999)(46102001)(99396002)(50986999)(95666004)(92726001)(42186005)(31966008)(48376002)(50466002)(81542001)(74502001)(16796002)(2201001)(105586002)(229853001)(44976005)(107046002)(36756003)(19580395003)(19580405001)(83322001)(68736004)(47776003)(92566001)(6806004)(64706001)(74662001)(45336002)(81342001)(76482001)(46386002)(97736003)(106466001)(20776003)(80022001)(90966001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR03MB493; H:tx30smr01.am.freescale.net; FPR:; MLV:ovrnspm; PTR:InfoDomainNonexistent; MX:1; A:0; LANG:en; MIME-Version: 1.0 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;UriScan:;UriScan:; X-Forefront-PRVS: 0329B15C8A Received-SPF: None (protection.outlook.com: shlinux1.ap.freescale.net does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is 192.88.168.50) smtp.mailfrom=b20596@shlinux1.ap.freescale.net; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:; X-OriginatorOrg: freescale.com Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fugang Duan Software clear the MDIO interrupt before MDIO bus access, but MAC still generate MDIO interrupt. The issue only happen on imx6slx chip. CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.17.0-rc1-00399-g0bcad17 #315 Backtrace: [<800121fc>] (dump_backtrace) from [<800124e0>] (show_stack+0x18/0x1c) r6:8096e534 r5:8096e534 r4:00000000 r3:00000000 [<800124c8>] (show_stack) from [<806a4c60>] (dump_stack+0x8c/0xa4) [<806a4bd4>] (dump_stack) from [<80060ab8>] (__lock_acquire+0x1814/0x1c40) r6:be078000 r5:be074000 r4:be03f6e4 r3:be078000 [<8005f2a4>] (__lock_acquire) from [<800616e0>] (lock_acquire+0x70/0x84) r10:809ada33 r9:be010600 r8:00000096 r7:00000001 r6:be074000 r5:00000000 r4:60000193 [<80061670>] (lock_acquire) from [<806abb20>] (_raw_spin_lock_irqsave+0x40/0x54) r7:00000000 r6:8005a3f8 r5:00000193 r4:be03f6d4 [<806abae0>] (_raw_spin_lock_irqsave) from [<8005a3f8>] (complete+0x1c/0x4c) r6:80950904 r5:be03f6d0 r4:be03f6d4 [<8005a3dc>] (complete) from [<8041b4c0>] (fec_enet_interrupt+0x128/0x164) r6:80950904 r5:00800000 r4:be03f000 r3:00000000 [<8041b398>] (fec_enet_interrupt) from [<8006aeac>] (handle_irq_event_percpu+0x38/0x13c) r6:00000000 r5:be01065c r4:be399e00 r3:8041b398 [<8006ae74>] (handle_irq_event_percpu) from [<8006aff4>] (handle_irq_event+0x44/0x64) r10:be03f000 r9:80989fe0 r8:00000000 r7:00000096 r6:be399e00 r5:be01065c r4:be010600 [<8006afb0>] (handle_irq_event) from [<8006e3e8>] (handle_fasteoi_irq+0xc8/0x1bc) r6:8096e764 r5:be01065c r4:be010600 r3:00000000 [<8006e320>] (handle_fasteoi_irq) from [<8006a63c>] (generic_handle_irq+0x30/0x44) r6:be074010 r5:80945e4c r4:00000096 r3:8006e320 [<8006a60c>] (generic_handle_irq) from [<8000f218>] (handle_IRQ+0x54/0xbc) r4:80950d74 r3:00000180 [<8000f1c4>] (handle_IRQ) from [<800086cc>] (gic_handle_irq+0x30/0x68) r8:be3ab478 r7:c080e100 r6:be075bd8 r5:80950eec r4:c080e10c r3:000000a0 [<8000869c>] (gic_handle_irq) from [<80013064>] (__irq_svc+0x44/0x5c) Signed-off-by: Fugang Duan Signed-off-by: Frank Li --- drivers/net/ethernet/freescale/fec_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 34ad932..5110181 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3061,6 +3061,7 @@ fec_probe(struct platform_device *pdev) goto failed_irq; } + init_completion(&fep->mdio_done); ret = fec_enet_mii_init(pdev); if (ret) goto failed_mii_init;