From patchwork Thu Aug 28 12:38:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vadym Kochan X-Patchwork-Id: 383821 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 541BA140120 for ; Thu, 28 Aug 2014 22:46:32 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbaH1MqU (ORCPT ); Thu, 28 Aug 2014 08:46:20 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:36434 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbaH1MqT (ORCPT ); Thu, 28 Aug 2014 08:46:19 -0400 Received: by mail-lb0-f170.google.com with SMTP id w7so831369lbi.29 for ; Thu, 28 Aug 2014 05:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=jRcC+1+ZhY2j3YuTr8dk3/dTmZF1BjHrX/WuHyU4+xI=; b=C5RWkOL0cajjwMwqsF+WCpHcp/J5NqJERnhm1wR+pbjFd8K4f3/XN0M9nJset1ua8B wCXOZQp4ISCJDg6p5hG/gzF1bnClR3YzotSmN7FyoYzS9QLtWjQiYHkAk3MuZJ5K4x3v XyP4V6WMxfmswFcLwVUniVCphr370Wav8cdG9g3MxFAl6SwCdlhlJuwUlkMIUJUyIzE6 g21BP7GTeIynAjJgGw4jhsbg9Gmd2JCtR2s4Nu4lW4pTZ0tFj0dVAyE1YDpM1lj7HBVv u1LGpJibSP0oDYwF01AWWCXPIUjf6/0roYGOvml5Vs41tLNl6kZGqCTwc2brcoE4UgML yxqQ== X-Received: by 10.152.179.229 with SMTP id dj5mr2575877lac.97.1409229977741; Thu, 28 Aug 2014 05:46:17 -0700 (PDT) Received: from angus-think.wlc.globallogic.com ([195.234.75.250]) by mx.google.com with ESMTPSA id jk1sm5854354lbc.6.2014.08.28.05.46.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 28 Aug 2014 05:46:16 -0700 (PDT) From: vadimk To: netdev@vger.kernel.org Cc: vadimk Subject: [PATCH] ip netns: Show error message if mkdir failed to create /var/run/netns Date: Thu, 28 Aug 2014 15:38:28 +0300 Message-Id: <1409229508-4652-1-git-send-email-vadim4j@gmail.com> X-Mailer: git-send-email 2.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Currently if mkdir failed with "Permission denied" error then "mount --make-shared ..." error message will be showed because /var/run/netns does not exist. --- ip/ipnetns.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 633b5b9..ee06eba 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -407,7 +407,11 @@ static int netns_add(int argc, char **argv) snprintf(netns_path, sizeof(netns_path), "%s/%s", NETNS_RUN_DIR, name); /* Create the base netns directory if it doesn't exist */ - mkdir(NETNS_RUN_DIR, S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH); + if (mkdir(NETNS_RUN_DIR, S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH)) { + fprintf(stderr, "mkdir %s failed: %s\n", + NETNS_RUN_DIR, strerror(errno)); + return -1; + } /* Make it possible for network namespace mounts to propagate between * mount namespaces. This makes it likely that a unmounting a network