diff mbox

6lowpan: Allow 6LoWPAN to be modular

Message ID 1407424003-15073-1-git-send-email-geert@linux-m68k.org
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Geert Uytterhoeven Aug. 7, 2014, 3:06 p.m. UTC
Change config symbol 6LOWPAN from type bool to type tristate, so
6LoWPAN can be built modular, just like IPV6

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 net/6lowpan/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marcel Holtmann Aug. 7, 2014, 4 p.m. UTC | #1
Hi Geert,

> Change config symbol 6LOWPAN from type bool to type tristate, so
> 6LoWPAN can be built modular, just like IPV6
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> net/6lowpan/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
> index 028a5c6d1f61..e4a02ef55102 100644
> --- a/net/6lowpan/Kconfig
> +++ b/net/6lowpan/Kconfig
> @@ -1,5 +1,5 @@
> config 6LOWPAN
> -	bool "6LoWPAN Support"
> +	tristate "6LoWPAN Support"

is this a regression from the previous CONFIG_6LOWPAN separation that we introduced? If it is, then it might be easiest if Dave just takes it into his net tree. Otherwise I take it through bluetooth-next.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven Aug. 7, 2014, 4:44 p.m. UTC | #2
Hi Marcel,

On Thu, Aug 7, 2014 at 6:00 PM, Marcel Holtmann <marcel@holtmann.org> wrote:
>> Change config symbol 6LOWPAN from type bool to type tristate, so
>> 6LoWPAN can be built modular, just like IPV6
>>
>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>> ---
>> net/6lowpan/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
>> index 028a5c6d1f61..e4a02ef55102 100644
>> --- a/net/6lowpan/Kconfig
>> +++ b/net/6lowpan/Kconfig
>> @@ -1,5 +1,5 @@
>> config 6LOWPAN
>> -     bool "6LoWPAN Support"
>> +     tristate "6LoWPAN Support"
>
> is this a regression from the previous CONFIG_6LOWPAN separation that we introduced? If it is, then it might be easiest if Dave just takes it into his net tree. Otherwise I take it through bluetooth-next.

I hadn't thought about that... Checking...

Yes, I believe this is a regression.

In v3.16, my allmodconfig build had:

CONFIG_IEEE802154_6LOWPAN=m
CONFIG_6LOWPAN_IPHC=m
CONFIG_BT_6LOWPAN=y

Without my patch it has:

CONFIG_6LOWPAN=y
CONFIG_IEEE802154_6LOWPAN=m
CONFIG_BT_6LOWPAN=m

and iphc is what's in net/6lowpan/built-in.o now.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marcel Holtmann Aug. 7, 2014, 6:31 p.m. UTC | #3
Hi Geert,

>>> Change config symbol 6LOWPAN from type bool to type tristate, so
>>> 6LoWPAN can be built modular, just like IPV6
>>> 
>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>> ---
>>> net/6lowpan/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
>>> index 028a5c6d1f61..e4a02ef55102 100644
>>> --- a/net/6lowpan/Kconfig
>>> +++ b/net/6lowpan/Kconfig
>>> @@ -1,5 +1,5 @@
>>> config 6LOWPAN
>>> -     bool "6LoWPAN Support"
>>> +     tristate "6LoWPAN Support"
>> 
>> is this a regression from the previous CONFIG_6LOWPAN separation that we introduced? If it is, then it might be easiest if Dave just takes it into his net tree. Otherwise I take it through bluetooth-next.
> 
> I hadn't thought about that... Checking...
> 
> Yes, I believe this is a regression.
> 
> In v3.16, my allmodconfig build had:
> 
> CONFIG_IEEE802154_6LOWPAN=m
> CONFIG_6LOWPAN_IPHC=m
> CONFIG_BT_6LOWPAN=y
> 
> Without my patch it has:
> 
> CONFIG_6LOWPAN=y
> CONFIG_IEEE802154_6LOWPAN=m
> CONFIG_BT_6LOWPAN=m
> 
> and iphc is what's in net/6lowpan/built-in.o now.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Dave, I am fine if you just queue this up for 3.17-rc1.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Alexander Aring Aug. 7, 2014, 6:49 p.m. UTC | #4
On Thu, Aug 07, 2014 at 05:06:43PM +0200, Geert Uytterhoeven wrote:
> Change config symbol 6LOWPAN from type bool to type tristate, so
> 6LoWPAN can be built modular, just like IPV6
> 

Acked-by: Alexander Aring <alex.aring@gmail.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Aug. 7, 2014, 7:05 p.m. UTC | #5
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu,  7 Aug 2014 17:06:43 +0200

> Change config symbol 6LOWPAN from type bool to type tristate, so
> 6LoWPAN can be built modular, just like IPV6
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/6lowpan/Kconfig b/net/6lowpan/Kconfig
index 028a5c6d1f61..e4a02ef55102 100644
--- a/net/6lowpan/Kconfig
+++ b/net/6lowpan/Kconfig
@@ -1,5 +1,5 @@ 
 config 6LOWPAN
-	bool "6LoWPAN Support"
+	tristate "6LoWPAN Support"
 	depends on IPV6
 	---help---
 	  This enables IPv6 over Low power Wireless Personal Area Network -