From patchwork Wed Jul 30 17:50:17 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Debabrata Banerjee X-Patchwork-Id: 374987 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4FB0C1400B9 for ; Thu, 31 Jul 2014 03:51:20 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755641AbaG3Ru7 (ORCPT ); Wed, 30 Jul 2014 13:50:59 -0400 Received: from prod-mail-xrelay07.akamai.com ([72.246.2.115]:30842 "EHLO prod-mail-xrelay07.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755268AbaG3Ru6 (ORCPT ); Wed, 30 Jul 2014 13:50:58 -0400 Received: from prod-mail-xrelay07.akamai.com (localhost.localdomain [127.0.0.1]) by postfix.imss70 (Postfix) with ESMTP id 7644A47577; Wed, 30 Jul 2014 17:50:57 +0000 (GMT) Received: from prod-mail-relay07.akamai.com (prod-mail-relay07.akamai.com [172.17.121.112]) by prod-mail-xrelay07.akamai.com (Postfix) with ESMTP id 610F1474F3; Wed, 30 Jul 2014 17:50:57 +0000 (GMT) Received: from bos-lpriq.kendall.corp.akamai.com (bos-lpriq.kendall.corp.akamai.com [172.28.12.108]) by prod-mail-relay07.akamai.com (Postfix) with ESMTP id 5CEC28003C; Wed, 30 Jul 2014 17:50:57 +0000 (GMT) Received: from dbanerje by bos-lpriq.kendall.corp.akamai.com with local (Exim 4.71) (envelope-from ) id 1XCY1h-0002lJ-BC; Wed, 30 Jul 2014 13:50:57 -0400 From: Debabrata Banerjee To: Sergei Shtylyov , netdev@vger.kernel.org, "David S . Miller" Cc: Debabrata Banerjee , Julian Anastasov , linux-kernel@vger.kernel.org Subject: [PATCH v2] tcp: don't require root to read tcp_metrics Date: Wed, 30 Jul 2014 13:50:17 -0400 Message-Id: <1406742617-10556-1-git-send-email-dbanerje@akamai.com> X-Mailer: git-send-email 2.0.3 In-Reply-To: <53D92D92.4090403@cogentembedded.com> References: <53D92D92.4090403@cogentembedded.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org commit d23ff7016 (tcp: add generic netlink support for tcp_metrics) introduced netlink support for the new tcp_metrics, however it restricted getting of tcp_metrics to root user only. This is a change from how these values could have been fetched when in the old route cache. Unless there's a legitimate reason to restrict the reading of these values it would be better if normal users could fetch them. Cc: Julian Anastasov Cc: linux-kernel@vger.kernel.org Signed-off-by: Debabrata Banerjee --- net/ipv4/tcp_metrics.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv4/tcp_metrics.c b/net/ipv4/tcp_metrics.c index 4fe0418..0d54e59 100644 --- a/net/ipv4/tcp_metrics.c +++ b/net/ipv4/tcp_metrics.c @@ -1093,7 +1093,6 @@ static const struct genl_ops tcp_metrics_nl_ops[] = { .doit = tcp_metrics_nl_cmd_get, .dumpit = tcp_metrics_nl_dump, .policy = tcp_metrics_nl_policy, - .flags = GENL_ADMIN_PERM, }, { .cmd = TCP_METRICS_CMD_DEL,