From patchwork Fri Jul 18 15:26:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benoit Taine X-Patchwork-Id: 371603 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A9DEF140139 for ; Sat, 19 Jul 2014 01:31:53 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030350AbaGRPbo (ORCPT ); Fri, 18 Jul 2014 11:31:44 -0400 Received: from isis.lip6.fr ([132.227.60.2]:54977 "EHLO isis.lip6.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965324AbaGRPbn (ORCPT ); Fri, 18 Jul 2014 11:31:43 -0400 X-Greylist: delayed 328 seconds by postgrey-1.27 at vger.kernel.org; Fri, 18 Jul 2014 11:31:37 EDT Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.14.7/lip6) with ESMTP id s6IFQ9CA029200 ; Fri, 18 Jul 2014 17:26:10 +0200 (CEST) X-pt: isis.lip6.fr Received: from localhost.localdomain (AMontsouris-651-1-237-186.w86-212.abo.wanadoo.fr [86.212.100.186]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPSA id CE3F56312; Fri, 18 Jul 2014 17:26:09 +0200 (CEST) From: Benoit Taine To: Don Fry Cc: benoit.taine@lip6.fr, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/25] pcnet32: Replace DEFINE_PCI_DEVICE_TABLE macro use Date: Fri, 18 Jul 2014 17:26:58 +0200 Message-Id: <1405697232-11785-12-git-send-email-benoit.taine@lip6.fr> X-Mailer: git-send-email 2.0.1 In-Reply-To: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr> References: <1405697232-11785-1-git-send-email-benoit.taine@lip6.fr> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 18 Jul 2014 17:26:10 +0200 (CEST) X-Scanned-By: MIMEDefang 2.74 on 132.227.60.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. Signed-off-by: Benoit Taine --- Tested by compilation without errors. drivers/net/ethernet/amd/pcnet32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index 4a8fdc4..e2e3aaf 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -61,7 +61,7 @@ static const char *const version = /* * PCI device identifiers for "new style" Linux PCI Device Drivers */ -static DEFINE_PCI_DEVICE_TABLE(pcnet32_pci_tbl) = { +static const struct pci_device_id pcnet32_pci_tbl[] = { { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_LANCE_HOME), }, { PCI_DEVICE(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_LANCE), },