From patchwork Mon Jul 14 10:08:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Olivier Sobrie X-Patchwork-Id: 369572 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 7FC2C140076 for ; Mon, 14 Jul 2014 20:09:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754859AbaGNKI6 (ORCPT ); Mon, 14 Jul 2014 06:08:58 -0400 Received: from mail-we0-f176.google.com ([74.125.82.176]:45057 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754202AbaGNKIt (ORCPT ); Mon, 14 Jul 2014 06:08:49 -0400 Received: by mail-we0-f176.google.com with SMTP id q58so410707wes.35 for ; Mon, 14 Jul 2014 03:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=9ZvrZEnj1qya3SeFvb08Ur+XRbMvLFFhr4IuPxl+zA4=; b=WydiOjjb75I/+12NnWik1/JRN63hu7xskTFswYLXBVz6WSo/c0aXy7I5iuFQE0mnc7 Z9eeWFLRnOgQrac6secSvotXI4F92rUASWI4IGBoOpHQaezztluJAyMXCo0BXWiGfpGs BnkX1ZDXpj6GEE+wUHiXp5yxsuZBSGSMmOeZXOI9URIOMUH+TgBnyyvoulzsubssFrZV 4SUnJf9uQEUI60Bod93Abns9XWUpIB3n3UTCBmbt8Uq001aYANqpyhaqr8M3Do2r4+LD ElarBKjU1IH0OE/soRq97dU3m1ed9ZoiTQs9x0LIRnAsiQvgKPfMNc47VkpeKg1oq4AS aNXw== X-Received: by 10.180.126.8 with SMTP id mu8mr23095328wib.10.1405332527515; Mon, 14 Jul 2014 03:08:47 -0700 (PDT) Received: from localhost.localdomain ([213.99.42.111]) by mx.google.com with ESMTPSA id lk5sm29346410wic.18.2014.07.14.03.08.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jul 2014 03:08:46 -0700 (PDT) From: Olivier Sobrie To: linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Olivier Sobrie Subject: [PATCH v2 1/2] hso: remove unused workqueue Date: Mon, 14 Jul 2014 12:08:49 +0200 Message-Id: <1405332530-2507-1-git-send-email-olivier@sobrie.be> X-Mailer: git-send-email 2.0.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The workqueue "retry_unthrottle_workqueue" is not scheduled anywhere in the code. So, remove it. Signed-off-by: Olivier Sobrie --- drivers/net/usb/hso.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index a3a0586..9ca2b41 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -261,7 +261,6 @@ struct hso_serial { u16 curr_rx_urb_offset; u8 rx_urb_filled[MAX_RX_URBS]; struct tasklet_struct unthrottle_tasklet; - struct work_struct retry_unthrottle_workqueue; }; struct hso_device { @@ -1252,14 +1251,6 @@ static void hso_unthrottle(struct tty_struct *tty) tasklet_hi_schedule(&serial->unthrottle_tasklet); } -static void hso_unthrottle_workfunc(struct work_struct *work) -{ - struct hso_serial *serial = - container_of(work, struct hso_serial, - retry_unthrottle_workqueue); - hso_unthrottle_tasklet(serial); -} - /* open the requested serial port */ static int hso_serial_open(struct tty_struct *tty, struct file *filp) { @@ -1295,8 +1286,6 @@ static int hso_serial_open(struct tty_struct *tty, struct file *filp) tasklet_init(&serial->unthrottle_tasklet, (void (*)(unsigned long))hso_unthrottle_tasklet, (unsigned long)serial); - INIT_WORK(&serial->retry_unthrottle_workqueue, - hso_unthrottle_workfunc); result = hso_start_serial_device(serial->parent, GFP_KERNEL); if (result) { hso_stop_serial_device(serial->parent); @@ -1345,7 +1334,6 @@ static void hso_serial_close(struct tty_struct *tty, struct file *filp) if (!usb_gone) hso_stop_serial_device(serial->parent); tasklet_kill(&serial->unthrottle_tasklet); - cancel_work_sync(&serial->retry_unthrottle_workqueue); } if (!usb_gone)