From patchwork Fri Jun 20 20:33:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Frederick X-Patchwork-Id: 362340 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6E0AC140086 for ; Sat, 21 Jun 2014 06:35:44 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757897AbaFTUe6 (ORCPT ); Fri, 20 Jun 2014 16:34:58 -0400 Received: from mailrelay011.isp.belgacom.be ([195.238.6.178]:19471 "EHLO mailrelay011.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbaFTUe5 (ORCPT ); Fri, 20 Jun 2014 16:34:57 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsHANaZpFNXQzOZ/2dsb2JhbABZgw2rRwUBAQEBAQEFAZkqgQ4XdYRgI4EaN4hGAcowF4ViiRQdhC0EmkSLMIgqg0Q7 Received: from 153.51-67-87.adsl-dyn.isp.belgacom.be (HELO linux-zvq9.site) ([87.67.51.153]) by relay.skynet.be with ESMTP; 20 Jun 2014 22:34:55 +0200 From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: Fabian Frederick , Jamal Hadi Salim , "David S. Miller" , netdev@vger.kernel.org Subject: [PATCH 1/1] net/sched/cls_bpf.c: remove null test before kfree Date: Fri, 20 Jun 2014 22:33:27 +0200 Message-Id: <1403296407-5877-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 1.8.4.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix checkpatch warning: WARNING: kfree(NULL) is safe this check is probably not required Cc: Jamal Hadi Salim Cc: "David S. Miller" Cc: netdev@vger.kernel.org Signed-off-by: Fabian Frederick --- net/sched/cls_bpf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c index 13f64df..715367a 100644 --- a/net/sched/cls_bpf.c +++ b/net/sched/cls_bpf.c @@ -212,8 +212,7 @@ static int cls_bpf_modify_existing(struct net *net, struct tcf_proto *tp, if (fp_old) sk_unattached_filter_destroy(fp_old); - if (bpf_old) - kfree(bpf_old); + kfree(bpf_old); return 0;