From patchwork Mon Jun 9 18:32:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Govindarajulu Varadarajan <_govind@gmx.com> X-Patchwork-Id: 357578 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 30E07140087 for ; Tue, 10 Jun 2014 04:34:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754357AbaFISeB (ORCPT ); Mon, 9 Jun 2014 14:34:01 -0400 Received: from mout.gmx.com ([74.208.4.201]:53113 "EHLO mout.gmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754320AbaFISd6 (ORCPT ); Mon, 9 Jun 2014 14:33:58 -0400 Received: from ws.cisco.com ([72.163.216.217]) by mail.gmx.com (mrgmxus002) with ESMTPSA (Nemesis) id 0LcBet-1WS7de3dTR-00jX6x; Mon, 09 Jun 2014 20:33:56 +0200 From: Govindarajulu Varadarajan <_govind@gmx.com> To: davem@davemloft.net, netdev@vger.kernel.org Cc: ssujith@cisco.com, gvaradar@cisco.com, benve@cisco.com, _govind@gmx.com Subject: [PATCH net-next 2/8] enic: fix return value in _vnic_dev_cmd Date: Tue, 10 Jun 2014 00:02:47 +0530 Message-Id: <1402338773-5996-3-git-send-email-_govind@gmx.com> X-Mailer: git-send-email 2.0.0 In-Reply-To: <1402338773-5996-1-git-send-email-_govind@gmx.com> References: <1402338773-5996-1-git-send-email-_govind@gmx.com> X-Provags-ID: V03:K0:T+/8Q7fLDxA4+N4ipogT3AJppyY/sahGmaFkfTeKKDsV3BlnGlo JYll9r8ntDTtgXidFZSmVzRhXd+4cuyV8h1MBDLyAsNH8+29ZBJ70R7LdktYipbOSxSFXf1 oThZf2SP8CSF8YtAiM3JLw+g/6wwZxiLKDdfMiEXXJCdu6qsz6gZQBS0cS2p+NfoX/vMBFD GU4VpwrLT61LQHcTOqzeg== Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hardware (in readq(&devcmd->args[0])) returns positive number in case of error. But _vnic_dev_cmd should return a negative value in case of error. Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com> --- drivers/net/ethernet/cisco/enic/vnic_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cisco/enic/vnic_dev.c b/drivers/net/ethernet/cisco/enic/vnic_dev.c index e86a45c..263081b 100644 --- a/drivers/net/ethernet/cisco/enic/vnic_dev.c +++ b/drivers/net/ethernet/cisco/enic/vnic_dev.c @@ -312,12 +312,12 @@ static int _vnic_dev_cmd(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, err = (int)readq(&devcmd->args[0]); if (err == ERR_EINVAL && cmd == CMD_CAPABILITY) - return err; + return -err; if (err != ERR_ECMDUNKNOWN || cmd != CMD_CAPABILITY) pr_err("Error %d devcmd %d\n", err, _CMD_N(cmd)); - return err; + return -err; } if (_CMD_DIR(cmd) & _CMD_DIR_READ) {