From patchwork Sun Jun 8 01:42:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rickard Strandqvist X-Patchwork-Id: 357176 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B7F5514008B for ; Sun, 8 Jun 2014 11:41:45 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753317AbaFHBlb (ORCPT ); Sat, 7 Jun 2014 21:41:31 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:38569 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192AbaFHBl3 (ORCPT ); Sat, 7 Jun 2014 21:41:29 -0400 Received: by mail-wi0-f174.google.com with SMTP id r20so2676757wiv.1 for ; Sat, 07 Jun 2014 18:41:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6BZKGkXKhgzjDNauuU1MRcHPiY5FQ7oBr0CQ4xSdDbA=; b=jSoi9faCN2vGqZmkIIaEZWgsrfYW0/+Fl6Ve8CQktwap/V1j/iE083EhCREHdioWix KnGqHwuSC7MunJghV2nuYQ+eUey4zLoKP1NShrbc/fnmcF/RmUmn+A7/6hyid6uEWZQE wpKoOqmKV9P5kmG28V/9L3Oa9MfGbqotzl8zPP/yeFgKqL/YR9OOy8Yzy51puBJq2Aby HT5Ciu8QRx+Xc7x6UwonUo4QfQxXfjybUgJ3ptiIGZmLsIQxYasHlUgV6MBeKWb1iJ24 po3eOLzZb7bmcWSDpJMoMwI2zS9G1SI1+5ENJDjHHCraB2/x8vTJF3gqWLasVo+qNxM6 8Olg== X-Gm-Message-State: ALoCoQnyINV8AxNtij5+wh3jQ1+13gM8UlIu4vmTwRLL5eka1mkPeJls9FSTrHByRXLvOMJkKSpv X-Received: by 10.14.204.73 with SMTP id g49mr2553107eeo.2.1402191688863; Sat, 07 Jun 2014 18:41:28 -0700 (PDT) Received: from localhost.localdomain (h-245-62.a218.priv.bahnhof.se. [85.24.245.62]) by mx.google.com with ESMTPSA id v45sm34215034eeg.29.2014.06.07.18.41.27 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Jun 2014 18:41:28 -0700 (PDT) From: Rickard Strandqvist To: Larry Finger , Chaoming Li Cc: Rickard Strandqvist , "John W. Linville" , Joe Perches , Peter Wu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: wireless: rtlwifi: rtl8723be: hw.c: Cleaning up if statement that always evaluates to false Date: Sun, 8 Jun 2014 03:42:23 +0200 Message-Id: <1402191743-26177-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I find a logical error in an if statement '(X & 0xfc) == 0x3' is always false After pointing this out, Larry Finger informed what would be the correct one. '(X & 0x3) == 0x3' Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/rtlwifi/rtl8723be/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/hw.c b/drivers/net/wireless/rtlwifi/rtl8723be/hw.c index 0fdf090..b61044f 100644 --- a/drivers/net/wireless/rtlwifi/rtl8723be/hw.c +++ b/drivers/net/wireless/rtlwifi/rtl8723be/hw.c @@ -1197,7 +1197,7 @@ static int _rtl8723be_set_media_status(struct ieee80211_hw *hw, } rtl_write_byte(rtlpriv, (MSR), bt_msr); rtlpriv->cfg->ops->led_control(hw, ledaction); - if ((bt_msr & 0x03) == MSR_AP) + if ((bt_msr & MSR_AP) == MSR_AP) rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00); else rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);