From patchwork Wed Jun 4 00:11:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 355683 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1B28814007F for ; Wed, 4 Jun 2014 10:12:36 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965053AbaFDAMU (ORCPT ); Tue, 3 Jun 2014 20:12:20 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:33604 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753815AbaFDAMS (ORCPT ); Tue, 3 Jun 2014 20:12:18 -0400 Received: by mail-pb0-f41.google.com with SMTP id uo5so6200610pbc.0 for ; Tue, 03 Jun 2014 17:12:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n6SeZEn+F9jrQM7h2+V5N4FQS9l5Rb64vS18crUwi9Y=; b=gk+dxjvv63gIe9uLQ1dBX3ypc/PBo79YH/KBuiy2dqqGqi7JrKbPLXBgeiZJURdC3b OjBOs133N6s2uolak54c+13TGV9yajFCFSUpWxGG/NNLbui7qfnJy/CSsMIbjudxKGUz mQcL51dhD+bTolmTZMMTgzuTZDWA+U7SGkBp7xgQGEWQATKL9O790L+5gQy8Z0TKJ2ln 4xpA1LO+sPiD3xBp7RtHGE6OK9+y9l41sqySTuikOmAwshWyGehfQ91qRBSnaCUr+J59 YIxE8U0FAeo36sYsMW8CHIs4f3yclVst2eI3j21TepoXrN0/BOdIgS5oEA3AsJDQ21Th DzYQ== X-Received: by 10.68.242.135 with SMTP id wq7mr56440622pbc.147.1401840736995; Tue, 03 Jun 2014 17:12:16 -0700 (PDT) Received: from localhost.net ([8.25.197.27]) by mx.google.com with ESMTPSA id xk3sm2404862pbb.65.2014.06.03.17.12.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jun 2014 17:12:16 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , "David S. Miller" Subject: [Patch net-next] net: remove some useless list_del() Date: Tue, 3 Jun 2014 17:11:55 -0700 Message-Id: <1401840715-16375-2-git-send-email-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1401840715-16375-1-git-send-email-xiyou.wangcong@gmail.com> References: <1401840715-16375-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org "list_kill" is allocated on stack and it's a list head, it is pointless to call list_del(&kill_list) especially after unregister_netdevice_many(). Cc: David S. Miller Signed-off-by: Cong Wang --- drivers/net/macvlan.c | 1 - net/core/rtnetlink.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index eee9106..cd80245 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1204,7 +1204,6 @@ static int macvlan_device_event(struct notifier_block *unused, list_for_each_entry_safe(vlan, next, &port->vlans, list) vlan->dev->rtnl_link_ops->dellink(vlan->dev, &list_kill); unregister_netdevice_many(&list_kill); - list_del(&list_kill); break; case NETDEV_PRE_TYPE_CHANGE: /* Forbid underlaying device to change its type. */ diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index f31268d..4a1cff6 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1770,7 +1770,6 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh) ops->dellink(dev, &list_kill); unregister_netdevice_many(&list_kill); - list_del(&list_kill); return 0; }