From patchwork Tue Jun 3 22:55:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 355667 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8C4D914007F for ; Wed, 4 Jun 2014 08:56:05 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965138AbaFCW4A (ORCPT ); Tue, 3 Jun 2014 18:56:00 -0400 Received: from mail-yk0-f180.google.com ([209.85.160.180]:60668 "EHLO mail-yk0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932485AbaFCW4A (ORCPT ); Tue, 3 Jun 2014 18:56:00 -0400 Received: by mail-yk0-f180.google.com with SMTP id q9so5439791ykb.39 for ; Tue, 03 Jun 2014 15:55:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cUF68oe2+gjK4BymCuUvj4SQ1JUPhVUXPZGXTvmhKWY=; b=PmEfU92s1KtPg6AuSW3zg0kFf+qcPbTxQ7YfrNbib6AhFCgeZIvJeENpp7lhcp0PFr hqndx73jeVe4f4mwlAR9FheiIo6fEzh8AeDyrInZhoC3bS9ffuymfVY/J+xduN150LaS sbXReiViBYVS0GiYTd1a+SfMVgg0ftWUEgieCsLBvFM/sBdO0YIGJEuFcPzpcuDVf1Ai XDA4913i9lqg+GNnEm0DF0kDMaiOzcsEJdiV5BTd5nTrJJgODMd/zpjwpbuGp7FP1pfx 3H8sn3fnqWpzj6u24p2hN8i6EtS0S0WT9LJt0BMpVtW6zVy44Y7J8vE4iO/4BnwTYk8w aHDg== X-Received: by 10.236.160.67 with SMTP id t43mr67611266yhk.11.1401836159309; Tue, 03 Jun 2014 15:55:59 -0700 (PDT) Received: from localhost.localdomain ([177.194.47.191]) by mx.google.com with ESMTPSA id i59sm1023939yhb.13.2014.06.03.15.55.57 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 03 Jun 2014 15:55:59 -0700 (PDT) From: Fabio Estevam To: davem@davemloft.net Cc: claudiu.manoil@freescale.com, netdev@vger.kernel.org, Fabio Estevam Subject: [PATCH] gianfar: Call netif_carrier_off() prior to registration Date: Tue, 3 Jun 2014 19:55:38 -0300 Message-Id: <1401836138-13253-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.8.3.2 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam Quoting David Miller: "At the moment you call register_netdev() the device is visible, notifications are sent to userspace, and userland tools can try to bring the interface up and see the incorrect link state, before you do the netif_carrier_off(). Said another way, between the register_netdev() and netif_carrier_off() call, userspace can see the device in an inconsistent state." So call netif_carrier_off() prior to register_netdev(). Signed-off-by: Fabio Estevam --- This is untested drivers/net/ethernet/freescale/gianfar.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index a7fe6a7..861e0c9 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1384,6 +1384,9 @@ static int gfar_probe(struct platform_device *ofdev) gfar_hw_init(priv); + /* Carrier starts down, phylib will bring it up */ + netif_carrier_off(dev); + err = register_netdev(dev); if (err) { @@ -1391,9 +1394,6 @@ static int gfar_probe(struct platform_device *ofdev) goto register_fail; } - /* Carrier starts down, phylib will bring it up */ - netif_carrier_off(dev); - device_init_wakeup(&dev->dev, priv->device_flags & FSL_GIANFAR_DEV_HAS_MAGIC_PACKET);