From patchwork Sat May 31 13:14:04 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Senna Tschudin X-Patchwork-Id: 354485 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8357F14009A for ; Sat, 31 May 2014 23:17:38 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935149AbaEaNRU (ORCPT ); Sat, 31 May 2014 09:17:20 -0400 Received: from mail-ve0-f174.google.com ([209.85.128.174]:36715 "EHLO mail-ve0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756596AbaEaNOg (ORCPT ); Sat, 31 May 2014 09:14:36 -0400 Received: by mail-ve0-f174.google.com with SMTP id jw12so3403600veb.33 for ; Sat, 31 May 2014 06:14:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=fig++A0VJDPMYF94ICBkR5fjfID9wH9pY+nARl9P6DM=; b=OXKrbBulq/AOK6ZQc7sn44iCOtBEH5pGL/cTqKv+K70OQpMC4DDOtX2pK6Ib2CJ4ic hPf1srdhlrOUDedO4TJdhIn+WKb5DtFussaXV5K9ZuTOOYdD2yKuS44MbJPPHwfxSJuD /wWUsgCQfU8YWGsm+i5LvTtRWDyZ14KcY8p2F3K/4+u8AqGKAz5aVT6VSsh0GXfU/i4Y 5tqoCbBTIBoGdcBeAvasXlwXYDtwdzUHTzRWY9oh1Z1CCKy1IGM6OzU26SYzZMBFIp5H zDtbHVUttM8q/PPzzHNKC6NnS8chKU7Fur4iLAP3EjtHrH3A3cXUg+0GorHOvPkJ2kHV dYmQ== X-Received: by 10.52.3.42 with SMTP id 10mr29391vdz.78.1401542075403; Sat, 31 May 2014 06:14:35 -0700 (PDT) Received: from localhost.localdomain ([201.45.91.211]) by mx.google.com with ESMTPSA id qr20sm12174405vdb.21.2014.05.31.06.14.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 31 May 2014 06:14:35 -0700 (PDT) From: Peter Senna Tschudin To: Samuel Ortiz Cc: kernel-janitors@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/11] via-ircc: Remove useless return variables Date: Sat, 31 May 2014 10:14:04 -0300 Message-Id: <1401542051-3174-4-git-send-email-peter.senna@gmail.com> X-Mailer: git-send-email 1.8.3.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret when strict return - ret + C ; // Signed-off-by: Peter Senna Tschudin --- drivers/net/irda/via-ircc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/irda/via-ircc.c b/drivers/net/irda/via-ircc.c index 2900af0..3fde116 100644 --- a/drivers/net/irda/via-ircc.c +++ b/drivers/net/irda/via-ircc.c @@ -509,11 +509,9 @@ static void via_hw_init(struct via_ircc_cb *self) * */ static int via_ircc_read_dongle_id(int iobase) -{ - int dongle_id = 9; /* Default to IBM */ - +{/* Default to IBM */ IRDA_ERROR("via-ircc: dongle probing not supported, please specify dongle_id module parameter.\n"); - return dongle_id; + return 9; } /* @@ -926,7 +924,6 @@ static int via_ircc_dma_xmit(struct via_ircc_cb *self, u16 iobase) static int via_ircc_dma_xmit_complete(struct via_ircc_cb *self) { int iobase; - int ret = TRUE; u8 Tx_status; IRDA_DEBUG(3, "%s()\n", __func__); @@ -983,7 +980,7 @@ F01_E*/ // Tell the network layer, that we can accept more frames netif_wake_queue(self->netdev); //F01 } - return ret; + return TRUE; } /*