From patchwork Wed Apr 9 15:05:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 337862 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DE3D71400A3 for ; Thu, 10 Apr 2014 01:05:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933354AbaDIPFk (ORCPT ); Wed, 9 Apr 2014 11:05:40 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:32895 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932826AbaDIPFe (ORCPT ); Wed, 9 Apr 2014 11:05:34 -0400 Received: by mail-ob0-f180.google.com with SMTP id wn1so2799738obc.39 for ; Wed, 09 Apr 2014 08:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=/T3lqGa3b87tl2f28NHx1h2JvxU/aq40cAr9gBbmcDo=; b=QjowtQA8xuuvGd0I8DZJguWXruociV0I8kmtRfp/ENX1N3bCTvXyyeK1LVr/8Tcalo BwnfxvLITGVOaPC2BFgEIDyQMlykXqWBvCVMFWSWGoA3vViHxUz0nih/EzQt5PROqZM7 kiUo2Zy+lokewVSbw5S/pX606KMoW+8fS8FKtM6OmGZLewj+L/YZ/yESnd2nHnhfQkDr TjplsPoMcTU+APCjGgh27YDsh1EASqIxwrl4zhkMG8v+NfTGZQjpIt+0+yeS717PwNHk L8GmqurxaMz8RKmGhDwTkDcBWcsJa0afdVpJ6qVrNu6QA4tQIjIuC5lkI66R/GMbf0WI o8oA== X-Received: by 10.182.2.72 with SMTP id 8mr9182604obs.21.1397055933973; Wed, 09 Apr 2014 08:05:33 -0700 (PDT) Received: from larrylap.lan (cpe-75-81-36-251.kc.res.rr.com. [75.81.36.251]) by mx.google.com with ESMTPSA id np9sm1271792obc.12.2014.04.09.08.05.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Apr 2014 08:05:33 -0700 (PDT) From: Larry Finger To: gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , Jes Sorensen , kbuild-all@01.org Subject: [PATCH] staging: r8723au: Fix build warnings Date: Wed, 9 Apr 2014 10:05:20 -0500 Message-Id: <1397055920-11654-1-git-send-email-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 1.8.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The kbuild test robot reports the following: tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 75ff24fa52f0cc512ceee4c377632b91a3a80811 commit: 9176303c404741b2f96796466437f2badf6e289b staging: r8723au: Turn on build of new driver date: 4 days ago config: make ARCH=avr32 allyesconfig All warnings: >> drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: 'rtw_set_roaming' declared inline after being called drivers/staging/rtl8723au/include/rtw_mlme.h:620: warning: previous declaration of 'rtw_set_roaming' was here >> drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: 'rtw_to_roaming' declared inline after being called drivers/staging/rtl8723au/include/rtw_mlme.h:621: warning: previous declaration of 'rtw_to_roaming' was here --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c: In function 'Hal_EEValueCheck': >> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:2277: warning: comparison is always true due to limited range of data type The first two warnings are fixed by making the two prototypes be "inline" to match the actual routine. The third warning comes from testing that a u8 quantity is positive. Reported-by: kbuild test robot Signed-off-by: Larry Finger Cc: Jes Sorensen Cc: kbuild-all@01.org --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- drivers/staging/rtl8723au/include/rtw_mlme.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 0a86923..dae61af 100644 --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c @@ -2277,7 +2277,7 @@ static void Hal_EEValueCheck(u8 EEType, void *pInValue, void *pOutValue) u8 *pIn, *pOut; pIn = (u8 *) pInValue; pOut = (u8 *) pOutValue; - if (*pIn >= 0 && *pIn <= 63) { + if (*pIn <= 63) { *pOut = *pIn; } else { RT_TRACE(_module_hci_hal_init_c_, _drv_err_, diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h b/drivers/staging/rtl8723au/include/rtw_mlme.h index 2d4f61b..3457b96 100644 --- a/drivers/staging/rtl8723au/include/rtw_mlme.h +++ b/drivers/staging/rtl8723au/include/rtw_mlme.h @@ -616,7 +616,7 @@ void _rtw23a_roaming(struct rtw_adapter *adapter, struct wlan_network *tgt_network); void rtw23a_roaming(struct rtw_adapter *adapter, struct wlan_network *tgt_network); -void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming); -u8 rtw_to_roaming(struct rtw_adapter *adapter); +inline void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming); +inline u8 rtw_to_roaming(struct rtw_adapter *adapter); #endif /* __RTL871X_MLME_H_ */