From patchwork Sun Mar 23 19:12:46 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Monam Agarwal X-Patchwork-Id: 332906 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4F7442C00CD for ; Mon, 24 Mar 2014 06:14:56 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbaCWTNt (ORCPT ); Sun, 23 Mar 2014 15:13:49 -0400 Received: from mail-pb0-f42.google.com ([209.85.160.42]:61678 "EHLO mail-pb0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751750AbaCWTNr (ORCPT ); Sun, 23 Mar 2014 15:13:47 -0400 Received: by mail-pb0-f42.google.com with SMTP id rr13so4537546pbb.29 for ; Sun, 23 Mar 2014 12:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id; bh=J+R+wBvaFCxIlWt5FfE4f+1hqOI1UvzR2edb+fnFEsQ=; b=VAd34Vad0qlcBfc4QW8+RK/oI375j13wdDHIoGB3tHDecGnLCdKg8pron9owimOhLa imgxUC5p+B+rSFzdUMUgtoOZBduaEEWpNwINfJhcnSbtvc9fEWPk1Lbha4d1F8mIi2/w Sx5S3HkMGZUgQqEhm0Ox2/f0T238TEGrmu8cU4XQtluoo8/l9MCdfW+Zw2ZkUeTjn3sc m/6/khLGGls0QySol7anBEUYvjK72xfqBT/nz+68mCoSYDkUCGq7FW8ZT3P0G6GiMaOM blQZwTRC4ho3ONG/qZ6sQjx2KXmn4peqo+ZGVBIRBa2/Adpld79C4IVU9yjiG3iWPXtm JPVA== X-Received: by 10.68.143.34 with SMTP id sb2mr4308657pbb.135.1395602027100; Sun, 23 Mar 2014 12:13:47 -0700 (PDT) Received: from hacker.iiit.ac.in ([14.139.82.6]) by mx.google.com with ESMTPSA id ge7sm26586164pbc.61.2014.03.23.12.13.42 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 23 Mar 2014 12:13:46 -0700 (PDT) From: Monam Agarwal To: davem@davemloft.net, ebiederm@xmission.com, nhorman@tuxdriver.com, cwang@twopensource.com, kaber@trash.net, antonio@meshcoding.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net/core: Use RCU_INIT_POINTER(x, NULL) in netpoll.c Date: Mon, 24 Mar 2014 00:42:46 +0530 Message-Id: <1395601966-12490-1-git-send-email-monamagarwal123@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) The rcu_assign_pointer() ensures that the initialization of a structure is carried out before storing a pointer to that structure. And in the case of the NULL pointer, there is no structure to initialize. So, rcu_assign_pointer(p, NULL) can be safely converted to RCU_INIT_POINTER(p, NULL) Signed-off-by: Monam Agarwal --- net/core/netpoll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 7291dde..41c4e9c 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -809,7 +809,7 @@ void __netpoll_cleanup(struct netpoll *np) if (ops->ndo_netpoll_cleanup) ops->ndo_netpoll_cleanup(np->dev); - rcu_assign_pointer(np->dev->npinfo, NULL); + RCU_INIT_POINTER(np->dev->npinfo, NULL); call_rcu_bh(&npinfo->rcu, rcu_cleanup_netpoll_info); } }