From patchwork Tue Mar 4 12:00:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hayes Wang X-Patchwork-Id: 326235 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id A68642C00A6 for ; Tue, 4 Mar 2014 23:04:33 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757266AbaCDMBz (ORCPT ); Tue, 4 Mar 2014 07:01:55 -0500 Received: from rtits2.realtek.com ([60.250.210.242]:36554 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757243AbaCDMBy (ORCPT ); Tue, 4 Mar 2014 07:01:54 -0500 X-SpamFilter-By: BOX Solutions SpamTrap 5.39 with qID s24C1pJX025520, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtitcas11.realtek.com.tw[172.21.6.12]) by rtits2.realtek.com (8.14.5/2.37/5.60) with ESMTP id s24C1pJX025520 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Tue, 4 Mar 2014 20:01:51 +0800 Received: from localhost.localdomain (172.21.71.77) by RTITCAS11.realtek.com.tw (172.21.6.12) with Microsoft SMTP Server id 14.3.174.1; Tue, 4 Mar 2014 20:01:52 +0800 From: Hayes Wang To: CC: , , , Hayes Wang Subject: [PATCH net-next 05/12] r8152: check tx agg list before spin lock Date: Tue, 4 Mar 2014 20:00:57 +0800 Message-ID: <1393934464-23675-6-git-send-email-hayeswang@realtek.com> X-Mailer: git-send-email 1.8.4.2 In-Reply-To: <1393934464-23675-1-git-send-email-hayeswang@realtek.com> References: <1393934464-23675-1-git-send-email-hayeswang@realtek.com> MIME-Version: 1.0 X-Originating-IP: [172.21.71.77] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Check tx agg list before spin lock to avoid doing spin lock every times. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 8ecb41b..00b3192 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -1266,6 +1266,9 @@ static struct tx_agg *r8152_get_tx_agg(struct r8152 *tp) struct tx_agg *agg = NULL; unsigned long flags; + if (list_empty(&tp->tx_free)) + return NULL; + spin_lock_irqsave(&tp->tx_lock, flags); if (!list_empty(&tp->tx_free)) { struct list_head *cursor;