From patchwork Fri Feb 14 14:32:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 320465 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9CA5F2C009E for ; Sat, 15 Feb 2014 01:32:35 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbaBNOcb (ORCPT ); Fri, 14 Feb 2014 09:32:31 -0500 Received: from www.linutronix.de ([62.245.132.108]:42331 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbaBNOcb (ORCPT ); Fri, 14 Feb 2014 09:32:31 -0500 Received: from localhost ([127.0.0.1] helo=bazinga.breakpoint.cc) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1WEJoZ-0000w4-LN; Fri, 14 Feb 2014 15:32:27 +0100 From: Sebastian Andrzej Siewior To: Grant Grundler Cc: netdev@vger.kernel.org, "David S. Miller" , Ingo Molnar , Thomas Gleixner , Sebastian Andrzej Siewior Subject: drivers/net: tulip_remove_one needs to call pci_disable_device() Date: Fri, 14 Feb 2014 15:32:20 +0100 Message-Id: <1392388340-6527-1-git-send-email-bigeasy@linutronix.de> X-Mailer: git-send-email 1.9.0.rc3 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ingo Molnar Otherwise the device is not completely shut down. Signed-off-by: Ingo Molnar Signed-off-by: Thomas Gleixner Signed-off-by: Sebastian Andrzej Siewior --- The patch is from "Date: Fri, 3 Jul 2009 08:30:18 -0500" and has been in -RT since. Now that I stumbled upon it and didn't notice anything -RT specific, here it comes. diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c index add05f1..1642de7 100644 --- a/drivers/net/ethernet/dec/tulip/tulip_core.c +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c @@ -1939,6 +1939,7 @@ static void tulip_remove_one(struct pci_dev *pdev) pci_iounmap(pdev, tp->base_addr); free_netdev (dev); pci_release_regions (pdev); + pci_disable_device(pdev); /* pci_power_off (pdev, -1); */ }