diff mbox

[ipsec-next,4/5] xfrm: fix checkpatch error

Message ID 1387536577-11480-5-git-send-email-chenweilong@huawei.com
State Awaiting Upstream, archived
Delegated to: David Miller
Headers show

Commit Message

chenweilong Dec. 20, 2013, 10:49 a.m. UTC
From: Weilong Chen <chenweilong@huawei.com>

Fix that "else should follow close brace '}'".

Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
 net/xfrm/xfrm_policy.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Sergei Shtylyov Dec. 20, 2013, 1:50 p.m. UTC | #1
Hello.

On 20-12-2013 14:49, Chen Weilong wrote:

> From: Weilong Chen <chenweilong@huawei.com>

> Fix that "else should follow close brace '}'".

> Signed-off-by: Weilong Chen <chenweilong@huawei.com>
> ---
>   net/xfrm/xfrm_policy.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

> diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
> index fbc72b4..0ed4770 100644
> --- a/net/xfrm/xfrm_policy.c
> +++ b/net/xfrm/xfrm_policy.c
> @@ -1316,8 +1316,7 @@ xfrm_tmpl_resolve_one(struct xfrm_policy *policy, const struct flowi *fl,
>   			error = (x->km.state == XFRM_STATE_ERROR ?
>   				 -EINVAL : -EAGAIN);
>   			xfrm_state_put(x);
> -		}
> -		else if (error == -ESRCH)
> +		} else if (error == -ESRCH)
>   			error = -EAGAIN;

    According to CodingStyle, both branches of *if* should have {}, if one has 
it. You may as well fix this.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c
index fbc72b4..0ed4770 100644
--- a/net/xfrm/xfrm_policy.c
+++ b/net/xfrm/xfrm_policy.c
@@ -1316,8 +1316,7 @@  xfrm_tmpl_resolve_one(struct xfrm_policy *policy, const struct flowi *fl,
 			error = (x->km.state == XFRM_STATE_ERROR ?
 				 -EINVAL : -EAGAIN);
 			xfrm_state_put(x);
-		}
-		else if (error == -ESRCH)
+		} else if (error == -ESRCH)
 			error = -EAGAIN;
 
 		if (!tmpl->optional)