From patchwork Mon Nov 11 16:44:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 290388 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1504B2C00D1 for ; Tue, 12 Nov 2013 03:44:46 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754228Ab3KKQom (ORCPT ); Mon, 11 Nov 2013 11:44:42 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34560 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753890Ab3KKQok (ORCPT ); Mon, 11 Nov 2013 11:44:40 -0500 Received: by mail-pa0-f48.google.com with SMTP id kq14so5588151pab.35 for ; Mon, 11 Nov 2013 08:44:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:content-transfer-encoding:mime-version; bh=GGJwz46brpiQu8U12tB0OpRaG6DALz5mNuWhaoX+eQc=; b=Z5gDMCffobcG6GlxXMqyjKZJlReUoGnUOYLlP/cg5ADjU+CcXP9SKTokH2nVqqsi/z EZ2MQ834l3+UnuUj4lRLRuieguCbPjQ3kT7OqCH0xxnowwvB5I41aCWHmclnXqqCq3nb Kq89z7+O9INYCSu8c7ixMSzyPf3zI8G6iSO4R6KvxfbVjmtaztfEV+Jpyicfyv1tx5px i27Tb5ejW4zMXyTGN/JiWdfeUXWfwkkqocW/SmjpSHb6tIWwoJ2wAEMsHaGjyeVusp1e OpFtQ9AKY6zdiJddj607viONRtRkySDiIFLBRZm/SuD11CBsPApxawMrLtxB/3y8mUvA Q8Zw== X-Received: by 10.67.4.197 with SMTP id cg5mr31668279pad.10.1384188278795; Mon, 11 Nov 2013 08:44:38 -0800 (PST) Received: from [172.19.243.157] ([172.19.243.157]) by mx.google.com with ESMTPSA id iu7sm31848102pbc.45.2013.11.11.08.44.37 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 11 Nov 2013 08:44:38 -0800 (PST) Message-ID: <1384188276.16391.45.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: TCP performance regression From: Eric Dumazet To: Sujith Manoharan Cc: Arnaud Ebalard , netdev@vger.kernel.org, Dave Taht , Thomas Petazzoni Date: Mon, 11 Nov 2013 08:44:36 -0800 In-Reply-To: <1384180787.16391.35.camel@edumazet-glaptop2.roam.corp.google.com> References: <21120.27501.32323.332316@gargle.gargle.HOWL> <1384149326.16391.10.camel@edumazet-glaptop2.roam.corp.google.com> <21120.29720.673157.151074@gargle.gargle.HOWL> <1384152853.16391.19.camel@edumazet-glaptop2.roam.corp.google.com> <21120.37647.979237.40802@gargle.gargle.HOWL> <1384180069.16391.32.camel@edumazet-glaptop2.roam.corp.google.com> <1384180787.16391.35.camel@edumazet-glaptop2.roam.corp.google.com> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 2013-11-11 at 06:39 -0800, Eric Dumazet wrote: > How following patch helps mvneta performance on current net-next tree > for a single TCP (sending) flow ? > v2 (more chance to even compile ;) --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 7d99e695a110..e8211277f15d 100644 --- a/drivers/net/ethernet/marvell/mvneta.c +++ b/drivers/net/ethernet/marvell/mvneta.c @@ -172,12 +172,12 @@ /* Various constants */ /* Coalescing */ -#define MVNETA_TXDONE_COAL_PKTS 16 +#define MVNETA_TXDONE_COAL_PKTS 1 #define MVNETA_RX_COAL_PKTS 32 #define MVNETA_RX_COAL_USEC 100 /* Timer */ -#define MVNETA_TX_DONE_TIMER_PERIOD 10 +#define MVNETA_TX_DONE_TIMER_PERIOD 1 /* Napi polling weight */ #define MVNETA_RX_POLL_WEIGHT 64