diff mbox

[1/2] net: if_arp: add ARPHRD_RAWIP type

Message ID 1383124271-15290-2-git-send-email-jukka.rissanen@linux.intel.com
State Deferred, archived
Delegated to: David Miller
Headers show

Commit Message

Jukka Rissanen Oct. 30, 2013, 9:11 a.m. UTC
This is used when there is no L2 header before IP header.
Example of this is Bluetooth 6LoWPAN network.

The RAWIP header type value is already used in some Android kernels
so same value is used here in order not to break userspace.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
---
 include/uapi/linux/if_arp.h | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller Oct. 30, 2013, 9:25 p.m. UTC | #1
From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Date: Wed, 30 Oct 2013 11:11:10 +0200

> This is used when there is no L2 header before IP header.
> Example of this is Bluetooth 6LoWPAN network.
> 
> The RAWIP header type value is already used in some Android kernels
> so same value is used here in order not to break userspace.
> 
> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>

I'm not applying patches like this until there is an actual user,
and this therefore goes for patch #2 as well.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marcel Holtmann Oct. 30, 2013, 10:26 p.m. UTC | #2
Hi Dave,

>> This is used when there is no L2 header before IP header.
>> Example of this is Bluetooth 6LoWPAN network.
>> 
>> The RAWIP header type value is already used in some Android kernels
>> so same value is used here in order not to break userspace.
>> 
>> Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
> 
> I'm not applying patches like this until there is an actual user,
> and this therefore goes for patch #2 as well.

patches for Bluetooth 6loWPAN have been posted to linux-bluetooth for review. So there is an actual user here.

If you do not want to merge these patches at this point, that is totally fine. We can happily carry them through bluetooth-next and wireless-next trees as well.

Posting them on netdev is mainly for checking that the changes we have to make outside the Bluetooth subsystem are in sync. So that they are reviewed and have been seen before. If you have any general objections to these assignments or changes, please let us now.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller Oct. 31, 2013, 4:27 a.m. UTC | #3
From: Marcel Holtmann <marcel@holtmann.org>
Date: Wed, 30 Oct 2013 23:26:37 +0100

> Posting them on netdev is mainly for checking that the changes we
> have to make outside the Bluetooth subsystem are in sync.

Changes without use context and examples cannot be reviewed.

You have to provide those example users here, not on some external
list for us to look at.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/include/uapi/linux/if_arp.h b/include/uapi/linux/if_arp.h
index d7fea34..06fc69f 100644
--- a/include/uapi/linux/if_arp.h
+++ b/include/uapi/linux/if_arp.h
@@ -59,6 +59,7 @@ 
 #define ARPHRD_LAPB	516		/* LAPB				*/
 #define ARPHRD_DDCMP    517		/* Digital's DDCMP protocol     */
 #define ARPHRD_RAWHDLC	518		/* Raw HDLC			*/
+#define ARPHRD_RAWIP	530	        /* Raw IP                       */
 
 #define ARPHRD_TUNNEL	768		/* IPIP tunnel			*/
 #define ARPHRD_TUNNEL6	769		/* IP6IP6 tunnel       		*/