| Message ID | 1382534936-23080-1-git-send-email-nikolay@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Wed, Oct 23, 2013 at 03:28:56PM +0200, Nikolay Aleksandrov wrote: >I think that a dev_put() is needed in the error path to preserve the >proper dev refcount. True, forgot about it. Thanks for spotting this! Acked-by: Veaceslav Falico <vfalico@redhat.com> > >CC: Veaceslav Falico <vfalico@redhat.com> >Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> >--- > net/core/dev.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/net/core/dev.c b/net/core/dev.c >index 0918aad..bdffd65 100644 >--- a/net/core/dev.c >+++ b/net/core/dev.c >@@ -4648,6 +4648,7 @@ remove_symlinks: > > free_adj: > kfree(adj); >+ dev_put(adj_dev); > > return ret; > } >-- >1.8.1.4 > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Nikolay Aleksandrov <nikolay@redhat.com> Date: Wed, 23 Oct 2013 15:28:56 +0200 > I think that a dev_put() is needed in the error path to preserve the > proper dev refcount. > > CC: Veaceslav Falico <vfalico@redhat.com> > Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index 0918aad..bdffd65 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4648,6 +4648,7 @@ remove_symlinks: free_adj: kfree(adj); + dev_put(adj_dev); return ret; }
I think that a dev_put() is needed in the error path to preserve the proper dev refcount. CC: Veaceslav Falico <vfalico@redhat.com> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> --- net/core/dev.c | 1 + 1 file changed, 1 insertion(+)