From patchwork Mon Sep 30 20:12:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 279251 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B8FC52C037B for ; Tue, 1 Oct 2013 06:13:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932089Ab3I3UMc (ORCPT ); Mon, 30 Sep 2013 16:12:32 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:46502 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932079Ab3I3UMa (ORCPT ); Mon, 30 Sep 2013 16:12:30 -0400 Received: by mail-ie0-f181.google.com with SMTP id tp5so10987315ieb.26 for ; Mon, 30 Sep 2013 13:12:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BfdlVGfyaB4Ir20V1GKsAvOzlCBgx5S+By8eac8ItYs=; b=mUwDC2LAaNWj8yhopwF+r/+M22n/J47gZRTAi5ns4BVK5vtW2L/A1irL8s5XicKvCD iZ6kgRwsN2nd+mY5R+onKP2TZfAB9vCYRmd6QCVAAvtVxx8bkbY3H5S5yTnKvjOHcMkj OlHwN1O1bjvqjeVHMvrhcSM2AYRhS7OTiqIQmZiGyly2fZYSFOT8M+yAFAZUmDvMNkeU iMsmcBd3VWsq4UP+y8zq855F/14blm9dyIyLYedgLQ7sQzzFFJ0EPZRCMpOcfl+Ggxd6 +GbyXpHD7uMo4GviQowSDbcH7tz6AUHG7wWQwF/m2LPqJJYGiGn++PXlXDM2lHzPYTVL SI9A== X-Received: by 10.50.73.41 with SMTP id i9mr15335305igv.30.1380571949549; Mon, 30 Sep 2013 13:12:29 -0700 (PDT) Received: from rob-laptop.calxeda.com ([173.226.190.126]) by mx.google.com with ESMTPSA id o8sm1697867igj.0.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 30 Sep 2013 13:12:28 -0700 (PDT) From: Rob Herring To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Rob Herring Subject: [PATCH 1/3] net: calxedaxgmac: fix clearing of old filter addresses Date: Mon, 30 Sep 2013 15:12:15 -0500 Message-Id: <1380571937-23439-2-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.8.1.2 In-Reply-To: <1380571937-23439-1-git-send-email-robherring2@gmail.com> References: <1380571937-23439-1-git-send-email-robherring2@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rob Herring In commit 2ee68f621af280 (net: calxedaxgmac: fix various errors in xgmac_set_rx_mode), a fix to clean-up old address entries was added. However, the loop to zero out the entries failed to increment the register address resulting in only 1 entry getting cleared. Fix this to correctly use the loop index. Also, the end of the loop condition was off by 1 and should have been <= rather than <. Signed-off-by: Rob Herring --- drivers/net/ethernet/calxeda/xgmac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/calxeda/xgmac.c b/drivers/net/ethernet/calxeda/xgmac.c index 78d6d6b..94358d2 100644 --- a/drivers/net/ethernet/calxeda/xgmac.c +++ b/drivers/net/ethernet/calxeda/xgmac.c @@ -1342,8 +1342,8 @@ static void xgmac_set_rx_mode(struct net_device *dev) } out: - for (i = reg; i < XGMAC_MAX_FILTER_ADDR; i++) - xgmac_set_mac_addr(ioaddr, NULL, reg); + for (i = reg; i <= XGMAC_MAX_FILTER_ADDR; i++) + xgmac_set_mac_addr(ioaddr, NULL, i); for (i = 0; i < XGMAC_NUM_HASH; i++) writel(hash_filter[i], ioaddr + XGMAC_HASH(i));