| Message ID | 1374945010-14667-1-git-send-email-nikolay@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Sat, Jul 27, 2013 at 07:10:10PM CEST, nikolay@redhat.com wrote: >After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we >have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired >with a read_lock because it's removed by that commit. Oups > >Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> Reviewed-by: Jiri Pirko <jiri@resnulli.us> >--- > drivers/net/bonding/bond_main.c | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index f584352..da3af63 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -739,7 +739,6 @@ static void bond_resend_igmp_join_requests(struct bonding *bond) > queue_delayed_work(bond->wq, &bond->mcast_work, HZ/5); > } > write_unlock_bh(&bond->curr_slave_lock); >- read_unlock(&bond->lock); > } > > static void bond_resend_igmp_join_requests_delayed(struct work_struct *work) >-- >1.8.1.4 > >-- >To unsubscribe from this list: send the line "unsubscribe netdev" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Jiri Pirko <jiri@resnulli.us> Date: Sat, 27 Jul 2013 22:07:54 +0200 > Sat, Jul 27, 2013 at 07:10:10PM CEST, nikolay@redhat.com wrote: >>After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we >>have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired >>with a read_lock because it's removed by that commit. > > Oups > >> >>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> > Reviewed-by: Jiri Pirko <jiri@resnulli.us> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index f584352..da3af63 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -739,7 +739,6 @@ static void bond_resend_igmp_join_requests(struct bonding *bond) queue_delayed_work(bond->wq, &bond->mcast_work, HZ/5); } write_unlock_bh(&bond->curr_slave_lock); - read_unlock(&bond->lock); } static void bond_resend_igmp_join_requests_delayed(struct work_struct *work)
After commit 4aa5dee4d9 ("net: convert resend IGMP to notifier event") we have 1 read_unlock in bond_resend_igmp_join_requests which isn't paired with a read_lock because it's removed by that commit. Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com> --- drivers/net/bonding/bond_main.c | 1 - 1 file changed, 1 deletion(-)