From patchwork Thu Nov 16 04:27:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838410 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="cUgQSf/A"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpHR6rSxz9s7G for ; Thu, 16 Nov 2017 15:32:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758863AbdKPE3o (ORCPT ); Wed, 15 Nov 2017 23:29:44 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:50991 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758697AbdKPE3I (ORCPT ); Wed, 15 Nov 2017 23:29:08 -0500 Received: by mail-pg0-f68.google.com with SMTP id u3so4543692pgn.7; Wed, 15 Nov 2017 20:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=rFJkt4SkxzlTentuBGwPeu3HrPpBLGVubixF6z0NtUM=; b=cUgQSf/AQvLFcYpvHVXv7jNPBRL3y1Z6W4TMMRaE7YIIucSVs7HSUsHHqhKdoquWB5 HXGr2UXLz0LvNDGlxP6Qq8Okym1XUzoUMMotlvceg4WlCsSC18BPb2UNTRIWqcWeOLyT WGiVSUfxTYlbn2ncnbwmywvHKfwOuEjBp9pyonhD/a+CC8YDOrYhaR0MjDQIhPmvINgO s52TSggpNQFey+YGjjB3FmcBcgGNlMTeHvTpfV84cOMyNdK3h38lGWmUL64f3CLQi9H9 S8Q3S8Q9w3JH/GYVafGyqsUMhnWUc2PLZtGyzt/Swu+xIcH0JR5r+E7ykZZAz2yRqM7o IOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=rFJkt4SkxzlTentuBGwPeu3HrPpBLGVubixF6z0NtUM=; b=uBliaUXghRQImAnVRpohuH9wASrmIyxU5eYZtb6SSH0DtCSzkMrGi4okbiZqO21VLY /SOBHxslIfp9MTqKt1oE8ETAwyLMF3N+KaZ+BAwrUk6w97tJs5uVuLXVcC4j591xQmEj 5RGXhwyd+WJBIDoLn22X00a2cyXFpTbKMFCXgjlX6EeMSQCPZShVCzO0BBjVWBsIDjj4 pl1weVF6mMVrm+sPGxuJquRA9qS/sNoP3A0eRqkgu8H4Nc+Z92biq6fLR7WtmSjHv9et qx0PkuWkTBF9R0O/D6Zi/8jgO3Ef1j7MY4qNzJCHl3gnEtlAh5ahjtN8rD3SFjXy8+ya b/Cg== X-Gm-Message-State: AJaThX5gYKJ9SwoVFzmnhfRuzW1aPKO4Ogk0iOsRe352lntrMFRCGNqp 79GjFthJG8ZSgFdM7Ex4dSQ= X-Google-Smtp-Source: AGs4zMakRdmwmxJpdzmKzvsKRX9I7ZN1wVnDVb7seOVzokYPtgwfsctiAGo5qcALwvqNY0pZnMnIbw== X-Received: by 10.98.87.13 with SMTP id l13mr437140pfb.193.1510806547746; Wed, 15 Nov 2017 20:29:07 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.29.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:29:07 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 06/12] isdn: hisax: Fix pnp_irq's error checking for setup_hfcs Date: Thu, 16 Nov 2017 09:57:23 +0530 Message-Id: <1372461dd91a1471b52a55207a527ce6580396b2.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/hfcscard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/hfcscard.c b/drivers/isdn/hisax/hfcscard.c index 4672870..3cbde72 100644 --- a/drivers/isdn/hisax/hfcscard.c +++ b/drivers/isdn/hisax/hfcscard.c @@ -195,7 +195,7 @@ int setup_hfcs(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "HFC PnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);