From patchwork Tue Jun 25 09:09:38 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Or Gerlitz X-Patchwork-Id: 254071 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B99242C0084 for ; Tue, 25 Jun 2013 19:11:19 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043Ab3FYJLO (ORCPT ); Tue, 25 Jun 2013 05:11:14 -0400 Received: from mailp.voltaire.com ([193.47.165.129]:40737 "EHLO mellanox.co.il" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751904Ab3FYJKZ (ORCPT ); Tue, 25 Jun 2013 05:10:25 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from ogerlitz@mellanox.com) with SMTP; 25 Jun 2013 12:10:18 +0300 Received: from r-vnc04.mtr.labs.mlnx (r-vnc04.mtr.labs.mlnx [10.208.0.116]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id r5P9A6D2002336; Tue, 25 Jun 2013 12:10:18 +0300 From: Or Gerlitz To: davem@davemloft.net Cc: netdev@vger.kernel.org, Jack Morgenstein , Vladimir Sokolovsky , Amir Vadai Subject: [PATCH V1 net-next 10/10] net/mlx4_core: Fail device init if num_vfs is negative Date: Tue, 25 Jun 2013 12:09:38 +0300 Message-Id: <1372151378-21468-11-git-send-email-ogerlitz@mellanox.com> X-Mailer: git-send-email 1.7.8.2 In-Reply-To: <1372151378-21468-1-git-send-email-ogerlitz@mellanox.com> References: <1372151378-21468-1-git-send-email-ogerlitz@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jack Morgenstein Should not allow negative num_vfs Signed-off-by: Jack Morgenstein Signed-off-by: Vladimir Sokolovsky Signed-off-by: Amir Vadai --- drivers/net/ethernet/mellanox/mlx4/main.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 81e4529..56160a2 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -2077,6 +2077,11 @@ static int __mlx4_init_one(struct pci_dev *pdev, int pci_dev_data) num_vfs, MLX4_MAX_NUM_VF); return -EINVAL; } + + if (num_vfs < 0) { + pr_err("num_vfs module parameter cannot be negative\n"); + return -EINVAL; + } /* * Check for BARs. */