diff mbox

[net-next] mlx4: use __netdev_pick_tx instead of __skb_tx_hash in mlx4_en_select_queue

Message ID 1370282862-13302-1-git-send-email-govindarajulu90@gmail.com
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

govindarajulu.v June 3, 2013, 6:07 p.m. UTC
From: "govindarajulu.v" <govindarajulu90@gmail.com>

mlx4_en_select_queue() uses __skb_tx_hash to select the transmit queue.
XPS settings are ignored by this. Instead, we can use __netdev_pick_tx
to select the transmit queue.

Compile test only.

Signed-off-by: govindarajulu.v <govindarajulu90@gmail.com>
---
 drivers/net/ethernet/mellanox/mlx4/en_tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller June 5, 2013, 12:30 a.m. UTC | #1
From: Amir Vadai <amirv@mellanox.com>
Date: Tue, 4 Jun 2013 13:52:14 +0300

> On 03/06/2013 21:07, govindarajulu.v wrote:
>> From: "govindarajulu.v" <govindarajulu90@gmail.com>
>> 
>> mlx4_en_select_queue() uses __skb_tx_hash to select the transmit queue.
>> XPS settings are ignored by this. Instead, we can use __netdev_pick_tx
>> to select the transmit queue.
>> 
>> Compile test only.
>> 
>> Signed-off-by: govindarajulu.v <govindarajulu90@gmail.com>
 ...
> Acked-By: Amir Vadai <amirv@mellanox.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_tx.c b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
index 4e6877a..7c49238 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_tx.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_tx.c
@@ -544,7 +544,7 @@  u16 mlx4_en_select_queue(struct net_device *dev, struct sk_buff *skb)
 	if (vlan_tx_tag_present(skb))
 		up = vlan_tx_tag_get(skb) >> VLAN_PRIO_SHIFT;
 
-	return __skb_tx_hash(dev, skb, rings_p_up) + up * rings_p_up;
+	return __netdev_pick_tx(dev, skb) % rings_p_up + up * rings_p_up;
 }
 
 static void mlx4_bf_copy(void __iomem *dst, unsigned long *src, unsigned bytecnt)