From patchwork Fri May 17 15:07:46 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Emilio_L=C3=B3pez?= X-Patchwork-Id: 244678 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3E1AF2C00D6 for ; Sat, 18 May 2013 02:02:41 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756595Ab3EQQCi (ORCPT ); Fri, 17 May 2013 12:02:38 -0400 Received: from zetta.elopez.com.ar ([199.30.59.35]:36620 "EHLO zetta.elopez.com.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756104Ab3EQQCg (ORCPT ); Fri, 17 May 2013 12:02:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=elopez.com.ar; s=mail; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=7E7mgXJje9J6P+3TOMt2p24CVvPQlOD1he/Pd4x9fsc=; b=mhjfi2RDcS+/arDlAQgmgkjUrm6EcvJ5Xpa/EDpqwXxJJ7GaNaWT9b55l0VfGzzzERZ65m+yKbfcG7Dj5I+FXysXAf4dmTS5Da0Cw6LhKwtQgr8T3vFd4trcmpq3YvoDEudY87ohd1I/Fw1E1GXr8FHsVOGnSplWWIVnX/uCUm1LyeA1OKrl+VEEaXjQpEjZGrE4xaf+8JW76i4SBfl5mBA7kJsE0TqK/ghS7ojZPmH/TalPeD55nRVaQm7xNHAiOWm4ifAlhVFVv2ZZ/VfO39b+fwzBokzTdUlukIWcg4BXC/+0vyEI7WrX+pcvl3zp4pHLWowG9oU3CoHheson9Q==; Received: from 201-212-118-238.prima.net.ar ([201.212.118.238] helo=desktop.lan) by zetta.elopez.com.ar with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) id 1UdMQb-0007WY-DS; Fri, 17 May 2013 12:18:41 -0300 From: =?UTF-8?q?Emilio=20L=C3=B3pez?= To: davem@davemloft.net Cc: netdev@vger.kernel.org, , =?UTF-8?q?Emilio=20L=C3=B3pez?= Subject: [PATCH 2/4] net: ethernet: apple: initialize variables directly Date: Fri, 17 May 2013 12:07:46 -0300 Message-Id: <1368803268-27698-2-git-send-email-emilio@elopez.com.ar> X-Mailer: git-send-email 1.8.2.3 In-Reply-To: <1368803268-27698-1-git-send-email-emilio@elopez.com.ar> References: <1368803268-27698-1-git-send-email-emilio@elopez.com.ar> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Clean up the code a bit to initialize the variables directly when defining them. Signed-off-by: Emilio López --- Please note that this patch is untested. drivers/net/ethernet/apple/bmac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index f36bbd6..253030c 100644 --- a/drivers/net/ethernet/apple/bmac.c +++ b/drivers/net/ethernet/apple/bmac.c @@ -1030,14 +1030,12 @@ static void bmac_set_multicast(struct net_device *dev) rx_cfg |= RxPromiscEnable; bmwrite(dev, RXCFG, rx_cfg); } else { - u16 hash_table[4]; + u16 hash_table[4] = {0}; rx_cfg = bmread(dev, RXCFG); rx_cfg &= ~RxPromiscEnable; bmwrite(dev, RXCFG, rx_cfg); - for(i = 0; i < 4; i++) hash_table[i] = 0; - netdev_for_each_mc_addr(ha, dev) { crc = ether_crc_le(6, ha->addr); crc >>= 26;