From patchwork Wed May 15 23:30:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 244202 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 468202C0099 for ; Thu, 16 May 2013 09:30:23 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428Ab3EOXaQ (ORCPT ); Wed, 15 May 2013 19:30:16 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:56920 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752408Ab3EOXaP (ORCPT ); Wed, 15 May 2013 19:30:15 -0400 Received: by mail-pb0-f41.google.com with SMTP id xb12so1794351pbc.0 for ; Wed, 15 May 2013 16:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:subject:from:to:cc:date:in-reply-to :references:content-type:x-mailer:content-transfer-encoding :mime-version; bh=T0WDFQi+ntJ1IOtCKdWf5xg3tDSTOa5djL6+L4EOa88=; b=vJeJHodOO/pL566/Vfg0OF1jNBI9dqUmwokcP9wkxA/oBpVf6E3xDq13gttThKblHt frYrzrxmol4hny3bd8xsnjZenxvhrIwknXmiZxdxi/1naRoSyC33KwLS1Aws0OORLKpR Nt5EF++f2MZLB8kFq1x++lwcsU47/mBLODiYym3wOYg3P9MUFnU5UIG2KVrhYINj9CeJ mioRoIlxA0tErYXfHNgXrIwNJ7zizTf3YlxxtxsmosCJsGV2qiEx+uyUwWmvAOC8SnPa e540tAbv7wff+zHV3hbgBKr4Vkh4bF03/CgKMjzsrO2Mnmd9oZnkLOCFo2Tw2VbiFsrV xDEA== X-Received: by 10.66.216.170 with SMTP id or10mr29403172pac.31.1368660615043; Wed, 15 May 2013 16:30:15 -0700 (PDT) Received: from ?IPv6:2620:0:1000:3304:98e:8918:b0af:bd56? ([2620:0:1000:3304:98e:8918:b0af:bd56]) by mx.google.com with ESMTPSA id b7sm4319024pba.39.2013.05.15.16.30.13 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Wed, 15 May 2013 16:30:14 -0700 (PDT) Message-ID: <1368660613.4519.60.camel@edumazet-glaptop> Subject: Re: [PATCH] bonding: allow TSO being set on bonding master From: Eric Dumazet To: =?UTF-8?Q?Micha=C5=82_Miros=C5=82aw?= Cc: David Miller , netdev , Jay Vosburgh , Maciej =?UTF-8?Q?=C5=BBenczykowski?= , Andy Gospodarek , Tom Herbert , Neal Cardwell , Yuchung Cheng Date: Wed, 15 May 2013 16:30:13 -0700 In-Reply-To: <1368659900.4519.57.camel@edumazet-glaptop> References: <1368654065.4519.53.camel@edumazet-glaptop> <1368659900.4519.57.camel@edumazet-glaptop> X-Mailer: Evolution 3.2.3-0ubuntu6 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2013-05-15 at 16:18 -0700, Eric Dumazet wrote: > On Thu, 2013-05-16 at 00:55 +0200, Michał Mirosław wrote: > > > Have you tried adding it to NETIF_F_ONE_FOR_ALL set? 'Team' and bridge > > could then also use it. > > Good point, I am testing this, thanks ! > Hmm, this doesnt work. # ethtool -k bond0 | grep tcp-segmentation-offload tcp-segmentation-offload: off # ethtool -K bond0 tso on # ethtool -k bond0 | grep tcp-segmentation-offload tcp-segmentation-offload: off Do you have something different in mind ? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 77f5202..c8d9db0 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -132,7 +132,7 @@ enum { * for all in netdev_increment_features. */ #define NETIF_F_ONE_FOR_ALL (NETIF_F_GSO_SOFTWARE | NETIF_F_GSO_ROBUST | \ - NETIF_F_SG | NETIF_F_HIGHDMA | \ + NETIF_F_SG | NETIF_F_HIGHDMA | NETIF_F_ALL_TSO | \ NETIF_F_FRAGLIST | NETIF_F_VLAN_CHALLENGED) /* * If one device doesn't support one of these features, then disable it