From patchwork Mon May 6 23:50:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Cross X-Patchwork-Id: 241854 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 61ACC2C00FD for ; Tue, 7 May 2013 09:58:02 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757927Ab3EFX54 (ORCPT ); Mon, 6 May 2013 19:57:56 -0400 Received: from mail-qe0-f74.google.com ([209.85.128.74]:35233 "EHLO mail-qe0-f74.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757135Ab3EFX5y (ORCPT ); Mon, 6 May 2013 19:57:54 -0400 Received: by mail-qe0-f74.google.com with SMTP id 1so448311qec.1 for ; Mon, 06 May 2013 16:57:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=+kxDTWqkbE2DgcUCHMApfpNM2A+h0ynQH9TCUldZ/1I=; b=FvFLlwQDRBEUbNZx++NYBRDXgRgJXQNSj8mCkYW8r7EpOZP+Zv7PJM1jJGItdfD4sr za7BBarg4R0lS3kJ1WdKgRrjF0ezIJGW9vMgkmBHoT1fluvjRroOA6Qlh5FfB9cW1PeN c8UOEqszT6kVyGxfLicAmvKV7FD52uWMlhty+gOuJlfZZE8fqXJ/ZXcL2TItD4jHR/TC jj0C1G4k6l9do+5DCAqunIIOUGcNUiBuSN+aMDwD+Y8L+dMY1JlhjY/QZinAKQXZ2i8T SUtNl3H6h7kkxYuox/fp4bMz4xE09uX9uJsKkoxGfLUFDIVFRj+XlXeIpW1HdS3rNXBH YbPg== X-Received: by 10.236.210.114 with SMTP id t78mr16928872yho.29.1367884235388; Mon, 06 May 2013 16:50:35 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id k33si2186876yhi.3.2013.05.06.16.50.35 for (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 06 May 2013 16:50:35 -0700 (PDT) Received: from walnut.mtv.corp.google.com (walnut.mtv.corp.google.com [172.18.105.48]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 392FA31C25C; Mon, 6 May 2013 16:50:35 -0700 (PDT) Received: by walnut.mtv.corp.google.com (Postfix, from userid 99897) id E078916078C; Mon, 6 May 2013 16:50:34 -0700 (PDT) From: Colin Cross To: linux-kernel@vger.kernel.org Cc: Pavel Machek , "Rafael J. Wysocki" , Peter Zijlstra , Ingo Molnar , Andrew Morton , Mandeep Singh Baines , Colin Cross , Oleg Nesterov , linux-nfs@vger.kernel.org, linux-pm@vger.kernel.org, netdev@vger.kernel.org, Linus Torvalds , Tejun Heo , Al Viro , "Eric W. Biederman" , Kees Cook Subject: [PATCH v3 15/16] sigtimedwait: use freezable blocking call Date: Mon, 6 May 2013 16:50:20 -0700 Message-Id: <1367884221-20462-16-git-send-email-ccross@android.com> X-Mailer: git-send-email 1.8.2.1 In-Reply-To: <1367884221-20462-1-git-send-email-ccross@android.com> References: <1367884221-20462-1-git-send-email-ccross@android.com> X-Gm-Message-State: ALoCoQlNr6b6B31oiTkDzl9JVLFa+w5UA4oLhDwuaV+p1sva9y0EB0+x1127SgiXVhsO2FDPVJMQO/h2rDJM1ezEPi7yx06cp/StRT1z/A+1Zf7kuEzv+TPAmt8U/C9koQaqX7OM2eOKVwBNW9MKq7jnRJSFF7TuPsVqeJKCRELziNjC4p3ucqo63i23f28yRCukFlVmly4t Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Avoid waking up every thread sleeping in a sigtimedwait call during suspend and resume by calling a freezable blocking call. Previous patches modified the freezer to avoid sending wakeups to threads that are blocked in freezable blocking calls. This call was selected to be converted to a freezable call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Acked-by: Tejun Heo Signed-off-by: Colin Cross --- kernel/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/signal.c b/kernel/signal.c index 598dc06..10a70a0 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -2845,7 +2845,7 @@ int do_sigtimedwait(const sigset_t *which, siginfo_t *info, recalc_sigpending(); spin_unlock_irq(&tsk->sighand->siglock); - timeout = schedule_timeout_interruptible(timeout); + timeout = freezable_schedule_timeout_interruptible(timeout); spin_lock_irq(&tsk->sighand->siglock); __set_task_blocked(tsk, &tsk->real_blocked);