From patchwork Sun Mar 24 06:10:25 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kumar Amit Mehta X-Patchwork-Id: 230365 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3C0862C00A1 for ; Sun, 24 Mar 2013 17:11:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756Ab3CXGKp (ORCPT ); Sun, 24 Mar 2013 02:10:45 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:38669 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690Ab3CXGKn (ORCPT ); Sun, 24 Mar 2013 02:10:43 -0400 Received: by mail-pa0-f43.google.com with SMTP id rl6so529838pac.2 for ; Sat, 23 Mar 2013 23:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=Yo0Anmcea++lfEYHSKnMOHGvfTxYZKwT68cFaCi/Mhc=; b=LlLhJcw3awR8izCQc9mLlQy1kmLFv5yLLX5FtIJTEm5QFqo51tzaXrD42Jal+0wxnq /3PeSwidfZgxKKj+wbBViYPllQsyosswwCNv4xbCFDb69us/f8lElBZnKnGLNdmUogJo SHeou7FgkADQbfP+095gg3WYcqSJB8lxp3iISTpQT+48jU0bsCLpudEYyyNJyUo2868d nj655Ca8WnNgCDvX8jEjHphu5isghXS8g7wQJ0CPctmxmrFLZG+rFHadlfj3b8aC6e5h 9ua091uv3GnPeZMDinstp3828faj0+XyNCy/5CBXKbRUoGIQBKW9Xt3vtuOweQNxfU7u nSuA== X-Received: by 10.66.178.5 with SMTP id cu5mr11784119pac.16.1364105442804; Sat, 23 Mar 2013 23:10:42 -0700 (PDT) Received: from localhost.localdomain ([117.208.162.7]) by mx.google.com with ESMTPS id ti8sm8586739pbc.12.2013.03.23.23.10.38 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 23 Mar 2013 23:10:42 -0700 (PDT) From: Kumar Amit Mehta To: eilong@broadcom.com Cc: davem@davemloft.net, dan.carpenter@oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH v2] bnx2x: fix assignment of signed expression to unsigned variable Date: Sat, 23 Mar 2013 23:10:25 -0700 Message-Id: <1364105425-8198-1-git-send-email-gmate.amit@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org fix for incorrect assignment of signed expression to unsigned variable. Signed-off-by: Kumar Amit Mehta Acked-by: Dmitry Kravkov --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c index 5682054..91ecd6a 100644 --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c @@ -2139,12 +2139,12 @@ static u8 bnx2x_dcbnl_get_cap(struct net_device *netdev, int capid, u8 *cap) break; default: BNX2X_ERR("Non valid capability ID\n"); - rval = -EINVAL; + rval = 1; break; } } else { DP(BNX2X_MSG_DCB, "DCB disabled\n"); - rval = -EINVAL; + rval = 1; } DP(BNX2X_MSG_DCB, "capid %d:%x\n", capid, *cap); @@ -2170,12 +2170,12 @@ static int bnx2x_dcbnl_get_numtcs(struct net_device *netdev, int tcid, u8 *num) break; default: BNX2X_ERR("Non valid TC-ID\n"); - rval = -EINVAL; + rval = 1; break; } } else { DP(BNX2X_MSG_DCB, "DCB disabled\n"); - rval = -EINVAL; + rval = 1; } return rval; @@ -2188,7 +2188,7 @@ static int bnx2x_dcbnl_set_numtcs(struct net_device *netdev, int tcid, u8 num) return -EINVAL; } -static u8 bnx2x_dcbnl_get_pfc_state(struct net_device *netdev) +static u8 bnx2x_dcbnl_get_pfc_state(struct net_device *netdev) { struct bnx2x *bp = netdev_priv(netdev); DP(BNX2X_MSG_DCB, "state = %d\n", bp->dcbx_local_feat.pfc.enabled); @@ -2390,12 +2390,12 @@ static u8 bnx2x_dcbnl_get_featcfg(struct net_device *netdev, int featid, break; default: BNX2X_ERR("Non valid featrue-ID\n"); - rval = -EINVAL; + rval = 1; break; } } else { DP(BNX2X_MSG_DCB, "DCB disabled\n"); - rval = -EINVAL; + rval = 1; } return rval; @@ -2431,12 +2431,12 @@ static u8 bnx2x_dcbnl_set_featcfg(struct net_device *netdev, int featid, break; default: BNX2X_ERR("Non valid featrue-ID\n"); - rval = -EINVAL; + rval = 1; break; } } else { DP(BNX2X_MSG_DCB, "dcbnl call not valid\n"); - rval = -EINVAL; + rval = 1; } return rval;