| Message ID | 1363803572-17039-1-git-send-email-festevam@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Fabio Estevam <festevam@gmail.com> Date: Wed, 20 Mar 2013 15:19:32 -0300 > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit ff43da86c69 (NET: FEC: dynamtic check DMA desc buff type) the > following build error happens when CONFIG_FEC=m > > ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined! > ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined! > ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined! > > Fix it by exporting the required fec_ptp symbols. > > Reported-by: Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Applied and queued up for -stable. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, On Wed, Mar 20, 2013 at 03:19:32PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@freescale.com> > > Since commit ff43da86c69 (NET: FEC: dynamtic check DMA desc buff type) the > following build error happens when CONFIG_FEC=m > > ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined! > ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined! > ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined! > > Fix it by exporting the required fec_ptp symbols. IMHO this is not sensible. There is no need to make the fec driver 2 modules. Just loading one is impossible (fec.ko) or useless (fec_ptp.ko). That's why I suggested to make them a single module. Best regards Uwe
On Wed, Mar 20, 2013 at 4:16 PM, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote: > Hello, > > On Wed, Mar 20, 2013 at 03:19:32PM -0300, Fabio Estevam wrote: >> From: Fabio Estevam <fabio.estevam@freescale.com> >> >> Since commit ff43da86c69 (NET: FEC: dynamtic check DMA desc buff type) the >> following build error happens when CONFIG_FEC=m >> >> ERROR: "fec_ptp_init" [drivers/net/ethernet/freescale/fec.ko] undefined! >> ERROR: "fec_ptp_ioctl" [drivers/net/ethernet/freescale/fec.ko] undefined! >> ERROR: "fec_ptp_start_cyclecounter" [drivers/net/ethernet/freescale/fec.ko] undefined! >> >> Fix it by exporting the required fec_ptp symbols. > IMHO this is not sensible. There is no need to make the fec driver 2 > modules. Just loading one is impossible (fec.ko) or useless > (fec_ptp.ko). That's why I suggested to make them a single module. Ok, I wil do as you suggested on a subsequent patch. Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/freescale/fec_ptp.c b/drivers/net/ethernet/freescale/fec_ptp.c index 1f17ca0..0d8df40 100644 --- a/drivers/net/ethernet/freescale/fec_ptp.c +++ b/drivers/net/ethernet/freescale/fec_ptp.c @@ -128,6 +128,7 @@ void fec_ptp_start_cyclecounter(struct net_device *ndev) spin_unlock_irqrestore(&fep->tmreg_lock, flags); } +EXPORT_SYMBOL(fec_ptp_start_cyclecounter); /** * fec_ptp_adjfreq - adjust ptp cycle frequency @@ -318,6 +319,7 @@ int fec_ptp_ioctl(struct net_device *ndev, struct ifreq *ifr, int cmd) return copy_to_user(ifr->ifr_data, &config, sizeof(config)) ? -EFAULT : 0; } +EXPORT_SYMBOL(fec_ptp_ioctl); /** * fec_time_keep - call timecounter_read every second to avoid timer overrun @@ -383,3 +385,4 @@ void fec_ptp_init(struct net_device *ndev, struct platform_device *pdev) pr_info("registered PHC device on %s\n", ndev->name); } } +EXPORT_SYMBOL(fec_ptp_init);