| Message ID | 1360328327-7144-8-git-send-email-jiri@resnulli.us |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Fri, 2013-02-08 at 13:58 +0100, Jiri Pirko wrote: > This check made bigger packets incorrectly dropped. Remove this > limitation for gso skbs. > > Signed-off-by: Jiri Pirko <jiri@resnulli.us> > --- > net/sched/sch_tbf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c > index 35bfd49..7ee5bff 100644 > --- a/net/sched/sch_tbf.c > +++ b/net/sched/sch_tbf.c > @@ -121,7 +121,7 @@ static int tbf_enqueue(struct sk_buff *skb, struct Qdisc *sch) > struct tbf_sched_data *q = qdisc_priv(sch); > int ret; > > - if (qdisc_pkt_len(skb) > q->max_size) > + if (qdisc_pkt_len(skb) > q->max_size && !skb_is_gso(skb)) > return qdisc_reshape_fail(skb, sch); > > ret = qdisc_enqueue(skb, q->qdisc); Acked-by: Eric Dumazet <edumazet@gogle.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c index 35bfd49..7ee5bff 100644 --- a/net/sched/sch_tbf.c +++ b/net/sched/sch_tbf.c @@ -121,7 +121,7 @@ static int tbf_enqueue(struct sk_buff *skb, struct Qdisc *sch) struct tbf_sched_data *q = qdisc_priv(sch); int ret; - if (qdisc_pkt_len(skb) > q->max_size) + if (qdisc_pkt_len(skb) > q->max_size && !skb_is_gso(skb)) return qdisc_reshape_fail(skb, sch); ret = qdisc_enqueue(skb, q->qdisc);
This check made bigger packets incorrectly dropped. Remove this limitation for gso skbs. Signed-off-by: Jiri Pirko <jiri@resnulli.us> --- net/sched/sch_tbf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)