From patchwork Sun Dec 30 11:58:16 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 208745 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4998C2C00B0 for ; Sun, 30 Dec 2012 23:00:27 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754535Ab2L3MAZ (ORCPT ); Sun, 30 Dec 2012 07:00:25 -0500 Received: from mail-ea0-f176.google.com ([209.85.215.176]:48139 "EHLO mail-ea0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754482Ab2L3MAX (ORCPT ); Sun, 30 Dec 2012 07:00:23 -0500 Received: by mail-ea0-f176.google.com with SMTP id d13so4951390eaa.35 for ; Sun, 30 Dec 2012 04:00:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=/sWEdCKKY0ky3+5HjjHWdsJs1DwAuu8Q4wbpTxIlMQk=; b=mgOXMT110Y90+0XuPjFW69UXuhqNURMbejgYqAScBn8+YOHXUi1Q/aUxfCaH1hQXiI gK4qA7akrtMAS7z24rAb+iWD2ykwdc894Mkx2VUS0ytmf1zlj3vgGQPceJKgSCf1v0mv J5AAzpiIuT7vKDMjLhCu85QEeigyUIxih3ZwQyG3jRg6PPDu/pTg/VqQJkZ1VPHfMBhw 7n4bttEUVIDio5HkwE1JarnKVXKe6fpHy+6Fuy0O1dqA6DO3raJSkuJXf4RuWMxdbTwM +PhDjBYKRNmggqEG/hO83INFA9fUXSnA7kjkPcOZEiDESyVjHxpRCPsh9PjU4QE3T4+C Eliw== X-Received: by 10.14.223.200 with SMTP id v48mr102778912eep.24.1356868821626; Sun, 30 Dec 2012 04:00:21 -0800 (PST) Received: from localhost (sun-0.pirko.cz. [84.16.102.25]) by mx.google.com with ESMTPS id 46sm78369029eeg.4.2012.12.30.04.00.13 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 30 Dec 2012 04:00:20 -0800 (PST) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, bhutchings@solarflare.com, faisal.latif@intel.com, shemminger@vyatta.com, fbl@redhat.com, roland@kernel.org, sean.hefty@intel.com, hal.rosenstock@gmail.com, fubar@us.ibm.com, andy@greyhouse.net, divy@chelsio.com, jitendra.kalsaria@qlogic.com, sony.chacko@qlogic.com, linux-driver@qlogic.com, kaber@trash.net, ursula.braun@de.ibm.com, blaschka@linux.vnet.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, ebiederm@xmission.com, joe@perches.com, amwang@redhat.com, nhorman@tuxdriver.com, john.r.fastabend@intel.com, pablo@netfilter.org Subject: [patch net-next 09/15] qlcnic: guard __vlan_find_dev_deep() by rcu_read_lock Date: Sun, 30 Dec 2012 12:58:16 +0100 Message-Id: <1356868702-8144-10-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1356868702-8144-1-git-send-email-jiri@resnulli.us> References: <1356868702-8144-1-git-send-email-jiri@resnulli.us> X-Gm-Message-State: ALoCoQkJe7iqcKD5FmN7bWZEPaGwE6N+XrQujQ77syqRVuTVaGXuRWIuHTOUZdRgp0Cd18R1omUW Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org rcu_read_lock was missing here Signed-off-by: Jiri Pirko --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index d833f59..95b628f 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -2867,12 +2867,14 @@ qlcnic_restore_indev_addr(struct net_device *netdev, unsigned long event) qlcnic_config_indev_addr(adapter, netdev, event); + rcu_read_lock(); for_each_set_bit(vid, adapter->vlans, VLAN_N_VID) { dev = __vlan_find_dev_deep(netdev, vid); if (!dev) continue; qlcnic_config_indev_addr(adapter, dev, event); } + rcu_read_unlock(); } static int qlcnic_netdev_event(struct notifier_block *this,