From patchwork Fri Nov 30 00:35:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Woodhouse X-Patchwork-Id: 202845 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0DFA82C008F for ; Fri, 30 Nov 2012 11:37:16 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755335Ab2K3Ags (ORCPT ); Thu, 29 Nov 2012 19:36:48 -0500 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:47064 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755298Ab2K3Agn (ORCPT ); Thu, 29 Nov 2012 19:36:43 -0500 Received: from shinybook.infradead.org ([2001:8b0:10b:1:e6ce:8fff:fe1f:f2c0]) by bombadil.infradead.org with esmtpsa (Exim 4.76 #1 (Red Hat Linux)) id 1TeEav-0002vc-OW; Fri, 30 Nov 2012 00:36:42 +0000 Received: from dwmw2 by shinybook.infradead.org with local (Exim 4.80.1 #2 (Red Hat Linux)) id 1TeEat-00072F-VA; Fri, 30 Nov 2012 00:36:40 +0000 From: David Woodhouse To: netdev@vger.kernel.org Cc: chas@cmf.nrl.navy.mil, krzysiek@podlesie.net, Nathan Williams , David Woodhouse Subject: [PATCH 12/17] solos-pci: Fix leak of skb received for unknown vcc Date: Fri, 30 Nov 2012 00:35:31 +0000 Message-Id: <1354235736-26833-13-git-send-email-dwmw2@infradead.org> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1354235736-26833-1-git-send-email-dwmw2@infradead.org> References: <1354235736-26833-1-git-send-email-dwmw2@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Nathan Williams ... and ensure that the next skb is set up for RX in the DMA case. Signed-off-by: Nathan Williams Signed-off-by: David Woodhouse --- drivers/atm/solos-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c index 387052d..6258961 100644 --- a/drivers/atm/solos-pci.c +++ b/drivers/atm/solos-pci.c @@ -711,7 +711,8 @@ void solos_bh(unsigned long card_arg) dev_warn(&card->dev->dev, "Received packet for unknown VPI.VCI %d.%d on port %d\n", le16_to_cpu(header->vpi), le16_to_cpu(header->vci), port); - continue; + dev_kfree_skb_any(skb); + break; } atm_charge(vcc, skb->truesize); vcc->push(vcc, skb);