From patchwork Mon Aug 20 13:34:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: danborkmann@iogearbox.net X-Patchwork-Id: 178777 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2EB2D2C0088 for ; Mon, 20 Aug 2012 23:34:22 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756072Ab2HTNeQ (ORCPT ); Mon, 20 Aug 2012 09:34:16 -0400 Received: from www62.your-server.de ([213.133.104.62]:53070 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755617Ab2HTNeP (ORCPT ); Mon, 20 Aug 2012 09:34:15 -0400 Received: from [78.46.5.203] (helo=sslproxy01.your-server.de) by www62.your-server.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.74) (envelope-from ) id 1T3S7O-0007v2-D8; Mon, 20 Aug 2012 15:34:10 +0200 Received: from [82.130.103.141] by sslproxy01.your-server.de with esmtpa (Exim 4.72) (envelope-from ) id 1T3SB8-0006zh-MH; Mon, 20 Aug 2012 15:38:02 +0200 Subject: [PATCH net-next] af_packet: use define instead of constant From: Daniel Borkmann To: davem@davemloft.net Cc: netdev@vger.kernel.org Date: Mon, 20 Aug 2012 15:34:03 +0200 Message-ID: <1345469643.22726.2.camel@thinkbox> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 X-Authenticated-Sender: danborkmann@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.97.3/15274/Mon Aug 20 11:09:27 2012) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Instead of using a hard-coded value for the status variable, it would make the code more readable to use its destined define from linux/if_packet.h. Signed-off-by: daniel.borkmann@tik.ee.ethz.ch --- net/packet/af_packet.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 226b2cd..3ee372a 100644 --- a/net/packet/af_packet.c +++ b/net/packet/af_packet.c @@ -855,7 +855,8 @@ static void prb_fill_vlan_info(struct tpacket_kbdq_core *pkc, ppd->hv1.tp_vlan_tci = vlan_tx_tag_get(pkc->skb); ppd->tp_status = TP_STATUS_VLAN_VALID; } else { - ppd->hv1.tp_vlan_tci = ppd->tp_status = 0; + ppd->hv1.tp_vlan_tci = 0; + ppd->tp_status = TP_STATUS_AVAILABLE; } } @@ -1943,7 +1944,7 @@ static int tpacket_snd(struct packet_sock *po, struct msghdr *msg) int tp_len, size_max; unsigned char *addr; int len_sum = 0; - int status = 0; + int status = TP_STATUS_AVAILABLE; int hlen, tlen; mutex_lock(&po->pg_vec_lock);