From patchwork Sun Jul 29 13:28:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Devendra Naga X-Patchwork-Id: 173923 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 04B2A2C0087 for ; Sun, 29 Jul 2012 23:29:04 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752976Ab2G2N26 (ORCPT ); Sun, 29 Jul 2012 09:28:58 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:46633 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752869Ab2G2N25 (ORCPT ); Sun, 29 Jul 2012 09:28:57 -0400 Received: by pbbrp8 with SMTP id rp8so8163590pbb.19 for ; Sun, 29 Jul 2012 06:28:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=cetkI28r41hjSzOae6FB3JaTaVADmWzuP3grZgt/kWU=; b=aFMZfG03ysrg4nXw2wrdYlQwu9SqLmvFHX1ND6dYNh47dpFxZENZdtiA1OMm51/sv7 XZkVwoRvviN58LQYmWPl1abRQRwV9DWficI0Hy+TMtpeGwdEIlf4RQduspee4wogCMJZ /OSQjB2ZH3pDm8C3s9LMwxpBysqXRLjDSHfTLJv45mRjzfn/4aYYfGTPhnL31UNWcT75 ZLhRTGPiL2Fr9G0OWSR4ItrXjRQ+K/SNSGVkcEKm0mozsUqxOgYanC2klf42mxa3vG3+ 1H9pbfREH7uQS5WjCo7ASNLDEZ2Or/KjvB/Qwd4nLdZVdp8ivSQMFd5KcVCs48Eco71C AdqA== Received: by 10.66.84.137 with SMTP id z9mr18098623pay.18.1343568537551; Sun, 29 Jul 2012 06:28:57 -0700 (PDT) Received: from localhost.localdomain ([122.167.173.22]) by mx.google.com with ESMTPS id of4sm5850495pbb.51.2012.07.29.06.28.53 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 29 Jul 2012 06:28:56 -0700 (PDT) From: Devendra Naga To: "David S. Miller" , Jeff Kirsher , David Howells , Jiri Pirko , Pradeep A Dalvi , netdev@vger.kernel.org Cc: Devendra Naga Subject: [PATCH] seeq: use PTR_RET at init_module of driver Date: Sun, 29 Jul 2012 19:13:47 +0545 Message-Id: <1343568527-12729-1-git-send-email-develkernel412222@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org the driver sees wether the dev_seeq pointer is having a error that can be read by using the PTR_ERR, and returns it at error case, other wise 0 at success case. the PTR_RET does the same thing, and use PTR_RET instead of redoing the code of PTR_RET Signed-off-by: Devendra Naga Acked-by: David Howells Reviewed-by: Jiri Pirko --- This patch is actually made by using coccinelle, and also by looking at the PTR_RET function. as its implementation is static int PTR_RET(void *ptr) { if (IS_ERR(ptr) return PTR_ERR(ptr); return 0; } by using this i removed the following code and replaced with PTR_RET.... drivers/net/ethernet/seeq/seeq8005.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/seeq/seeq8005.c b/drivers/net/ethernet/seeq/seeq8005.c index 698edbb..d6e50de 100644 --- a/drivers/net/ethernet/seeq/seeq8005.c +++ b/drivers/net/ethernet/seeq/seeq8005.c @@ -736,9 +736,7 @@ MODULE_PARM_DESC(irq, "SEEQ 8005 IRQ number"); int __init init_module(void) { dev_seeq = seeq8005_probe(-1); - if (IS_ERR(dev_seeq)) - return PTR_ERR(dev_seeq); - return 0; + return PTR_RET(dev_seeq); } void __exit cleanup_module(void)