From patchwork Tue Jul 10 08:02:42 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li RongQing X-Patchwork-Id: 170074 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 94D412C0220 for ; Tue, 10 Jul 2012 18:03:02 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754226Ab2GJIC7 (ORCPT ); Tue, 10 Jul 2012 04:02:59 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:46390 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752848Ab2GJICz (ORCPT ); Tue, 10 Jul 2012 04:02:55 -0400 Received: by qcro28 with SMTP id o28so7191904qcr.19 for ; Tue, 10 Jul 2012 01:02:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer; bh=uQvVWrALfN1RTq4W0mEJ3AeObxi2gsHs4W8I5+ZpQYU=; b=kOFMaPDbXZnL8bCBz0QGbIYmunl/7Uj9IMWm1g//3zH3OE41M4C67dEg6YAIJscTzS se1YCW608WLBKf9nMW1QwbCEAUoTzKFHhPKypheR0WoDtRdluWFiCrROUH2JOH1RSq0f UiN3X/e1L5rPFW1vMr8+QY60qPPWVo4y+mKvJ4FSWzu739W+9YNY7B49MlX5PaT8nKpu de5KmEVQBeedhWbCXy4FFAj/XW4IISre7LcZP8F/E1R+COg77OVF+ttXBgHhAPzHlk13 xxI54WKQp1J67SVntcurztX9MUcS096VW3rI9IN4iMcDNlLgnlvRT+isKNewaAfm7bG8 O+fg== Received: by 10.224.177.1 with SMTP id bg1mr29653753qab.68.1341907374304; Tue, 10 Jul 2012 01:02:54 -0700 (PDT) Received: from localhost ([61.148.56.138]) by mx.google.com with ESMTPS id ej1sm12103182qab.11.2012.07.10.01.02.50 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 10 Jul 2012 01:02:53 -0700 (PDT) From: roy.qing.li@gmail.com To: netdev@vger.kernel.org Subject: [v2 PATCH] qlge: fix endian issue Date: Tue, 10 Jul 2012 16:02:42 +0800 Message-Id: <1341907362-17752-1-git-send-email-roy.qing.li@gmail.com> X-Mailer: git-send-email 1.7.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Li RongQing commit 6d29b1ef introduces a bug, ntohs is __be16_to_cpu, not cpu_to_be16. We always use htons on IP_OFFSET and IP_MF, then compare with network package. Signed-off-by: Li RongQing --- v2 : Change my name drivers/net/ethernet/qlogic/qlge/qlge_main.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c index 09d8d33..7c520fa 100644 --- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c +++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c @@ -1546,7 +1546,7 @@ static void ql_process_mac_rx_page(struct ql_adapter *qdev, struct iphdr *iph = (struct iphdr *) ((u8 *)addr + ETH_HLEN); if (!(iph->frag_off & - cpu_to_be16(IP_MF|IP_OFFSET))) { + htons(IP_MF|IP_OFFSET))) { skb->ip_summed = CHECKSUM_UNNECESSARY; netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, @@ -1654,7 +1654,7 @@ static void ql_process_mac_rx_skb(struct ql_adapter *qdev, /* Unfragmented ipv4 UDP frame. */ struct iphdr *iph = (struct iphdr *) skb->data; if (!(iph->frag_off & - ntohs(IP_MF|IP_OFFSET))) { + htons(IP_MF|IP_OFFSET))) { skb->ip_summed = CHECKSUM_UNNECESSARY; netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, @@ -1968,7 +1968,7 @@ static void ql_process_mac_split_rx_intr(struct ql_adapter *qdev, /* Unfragmented ipv4 UDP frame. */ struct iphdr *iph = (struct iphdr *) skb->data; if (!(iph->frag_off & - ntohs(IP_MF|IP_OFFSET))) { + htons(IP_MF|IP_OFFSET))) { skb->ip_summed = CHECKSUM_UNNECESSARY; netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev, "TCP checksum done!\n");