From patchwork Sun May 27 13:59:44 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 161542 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 85BB9B6EE7 for ; Sun, 27 May 2012 23:59:54 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752699Ab2E0N7v (ORCPT ); Sun, 27 May 2012 09:59:51 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:47501 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469Ab2E0N7t (ORCPT ); Sun, 27 May 2012 09:59:49 -0400 Received: by wibhj8 with SMTP id hj8so947808wib.1 for ; Sun, 27 May 2012 06:59:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; bh=vd9LZXz6vbR11Q2/CCg2sTwzupOVfOV58MJw9JGBlbw=; b=BcI4cIqOXfE2jxgTfk16hN1n7Plx1bNdHkS1V2DFPFumQOfHYNYcFweN52HXpAMPox s1T6o2/lfDjE2I2yRrjt+eQZDB8Ck/kvRPGRSzeQo0ITYM4KWS+BhtPLzoNggxXelNTm y1ZSQnpkpPFKckEDhGuzx4OcoxLX7TBHS9+oDUPxfdeKrJsl7uPwgf1kQfeiAzLaPGQS BF1nrqFzNI7BZywCbpsfqksXooOIqLNYhui5KCU4V8Cau4zLnxCcKj7Lo0jPEwn5hSIJ 2BuGjn3EEoXsm9Nh4BbTpuguN8U7HWctBaIlcZd7LioVm3X/nEXoewRl7PbgzPUEoevl dHoA== Received: by 10.180.106.137 with SMTP id gu9mr9228214wib.8.1338127188555; Sun, 27 May 2012 06:59:48 -0700 (PDT) Received: from [172.30.42.18] (122.237.66.86.rev.sfr.net. [86.66.237.122]) by mx.google.com with ESMTPS id fo7sm13687148wib.9.2012.05.27.06.59.46 (version=SSLv3 cipher=OTHER); Sun, 27 May 2012 06:59:47 -0700 (PDT) Subject: Re: WARNING: at net/ipv4/tcp.c:1610 tcp_recvmsg+0xb1b/0xc70() From: Eric Dumazet To: Jack Stone Cc: davem@davemloft.net, netdev@vger.kernel.org, Linux Kernel In-Reply-To: <4FC0BCE1.6070601@fastmail.fm> References: <4FBFEACC.8040601@fastmail.fm> <1337978725.10135.0.camel@edumazet-glaptop> <1337979331.10135.2.camel@edumazet-glaptop> <4FC0BCE1.6070601@fastmail.fm> Date: Sun, 27 May 2012 15:59:44 +0200 Message-ID: <1338127184.3670.50.camel@edumazet-glaptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 2012-05-26 at 12:22 +0100, Jack Stone wrote: > I'm still getting this with da89fb1 which includes the above > > Linux hover1 3.4.0-07797-gda89fb1 #4 SMP Fri May 25 22:23:14 BST 2012 x86_64 x86_64 x86_64 GNU/Linux Thanks Could you add following debugging patch ? --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 3ba605f..b56c63c 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -1606,8 +1606,9 @@ int tcp_recvmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg, if (tcp_hdr(skb)->fin) goto found_fin_ok; WARN(!(flags & MSG_PEEK), - "recvmsg bug 2: copied %X seq %X rcvnxt %X fl %X\n", - *seq, TCP_SKB_CB(skb)->seq, tp->rcv_nxt, flags); + "recvmsg bug 2: copied %X seq %X end_seq %X rcvnxt %X fl %X offset %u len %u syn %d\n", + *seq, TCP_SKB_CB(skb)->seq, TCP_SKB_CB(skb)->end_seq, + tp->rcv_nxt, flags, offset, skb->len, tcp_hdr(skb)->syn); } /* Well, if we have backlog, try to process it now yet. */