| Message ID | 1335972259-20975-1-git-send-email-c.hemp@phytec.de |
|---|---|
| State | Rejected, archived |
| Delegated to: | David Miller |
| Headers | show |
> A timeout of two minutes is pretty anoying if _no_ ethernet cable > is attached by purpose. This patch decreases the timeout of > CONF_CARRIER_TIMEOUT to an accaptable value of 10 secounds. > ... > > /* Define the friendly delay before and after opening net devices */ > #define CONF_POST_OPEN 10 /* After > opening: 10 msecs */ > -#define CONF_CARRIER_TIMEOUT 120000 /* Wait for carrier timeout */ > +#define CONF_CARRIER_TIMEOUT 1000 /* Wait for carrier timeout */ Doesn't that reduce it to 1 second! I'm also not all sure how long it might take. I'm sure there are some switches/routers that can take quite a while do negotiate the link. Usually noticed when dhcp takes links down and up as it assigns an address. David -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Christian Hemp <c.hemp@phytec.de> Date: Wed, 2 May 2012 17:24:19 +0200 > A timeout of two minutes is pretty anoying if _no_ ethernet cable > is attached by purpose. This patch decreases the timeout of > CONF_CARRIER_TIMEOUT to an accaptable value of 10 secounds. > > Signed-off-by: Christian Hemp <c.hemp@phytec.de> It was increased to 2 minutes intentionally, therefore you better go look into the history of why this was done and you better explain in your commit message why those issues don't matter. Otherwise your patch will be completely ignored. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c index 99ec116..2aa80ac 100644 --- a/net/ipv4/ipconfig.c +++ b/net/ipv4/ipconfig.c @@ -89,7 +89,7 @@ /* Define the friendly delay before and after opening net devices */ #define CONF_POST_OPEN 10 /* After opening: 10 msecs */ -#define CONF_CARRIER_TIMEOUT 120000 /* Wait for carrier timeout */ +#define CONF_CARRIER_TIMEOUT 1000 /* Wait for carrier timeout */ /* Define the timeout for waiting for a DHCP/BOOTP/RARP reply */ #define CONF_OPEN_RETRIES 2 /* (Re)open devices twice */
A timeout of two minutes is pretty anoying if _no_ ethernet cable is attached by purpose. This patch decreases the timeout of CONF_CARRIER_TIMEOUT to an accaptable value of 10 secounds. Signed-off-by: Christian Hemp <c.hemp@phytec.de> --- net/ipv4/ipconfig.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)