From patchwork Sat Apr 14 09:59:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Huang, Xiong" X-Patchwork-Id: 152496 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D8324B7007 for ; Sat, 14 Apr 2012 20:04:20 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176Ab2DNKEF (ORCPT ); Sat, 14 Apr 2012 06:04:05 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:62721 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753666Ab2DNKAz (ORCPT ); Sat, 14 Apr 2012 06:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=xiong@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1334397655; x=1365933655; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=dK4Hl1t57Z02JWYcplld+JVS7VhprBIH08vJjUt9CEM=; b=JlkzE2LkiLR10fug2HnIu+0vQYaNYnz7URgFYaRRL/9aNCQS3ybTaPp9 RYVmUwCnKI2KMlTuZ4KU3LO6BeSOE5olS88wyktrDrp1LALRI7txugu5v uzvyuMzlq1xA6AhVfB0SnsHDpMOo1lOZLG1maJboyybHWaa0ZCqEptKg8 o=; X-IronPort-AV: E=McAfee;i="5400,1158,6679"; a="181704227" Received: from ironmsg02-r.qualcomm.com ([172.30.46.16]) by wolverine01.qualcomm.com with ESMTP; 14 Apr 2012 03:00:55 -0700 X-IronPort-AV: E=Sophos;i="4.75,420,1330934400"; d="scan'208";a="158629061" Received: from nasanexhc07.na.qualcomm.com ([172.30.39.190]) by ironmsg02-R.qualcomm.com with ESMTP/TLS/AES128-SHA; 14 Apr 2012 03:00:54 -0700 Received: from qcmail1.qualcomm.com (172.30.39.5) by qcmail1.qualcomm.com (172.30.39.190) with Microsoft SMTP Server (TLS) id 14.2.283.3; Sat, 14 Apr 2012 03:00:53 -0700 Received: by qcmail1.qualcomm.com (sSMTP sendmail emulation); Sat, 14 Apr 2012 18:00:49 +0800 From: xiong To: , , CC: , , xiong Subject: [PATCH 04/12] atl1c: remove VPD register Date: Sat, 14 Apr 2012 17:59:20 +0800 Message-ID: <1334397568-8444-5-git-send-email-xiong@qca.qualcomm.com> X-Mailer: git-send-email 1.7.7 In-Reply-To: <1334397568-8444-1-git-send-email-xiong@qca.qualcomm.com> References: <1334397568-8444-1-git-send-email-xiong@qca.qualcomm.com> MIME-Version: 1.0 X-Originating-IP: [172.30.39.5] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org VPD register is only used for L1(devid=PCI_DEVICE_ID_ATTANSIC_L1) to access external NV-memory. l1c & later chip doesn't use it any more. no special userspace tool interpret the dumpped registers. dumpping them via ethtool is just for debug. Signed-off-by: xiong Tested-by: Liu David --- drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c | 1 - drivers/net/ethernet/atheros/atl1c/atl1c_hw.h | 11 ----------- 2 files changed, 0 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c b/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c index 0a9326a..ce63615 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c @@ -142,7 +142,6 @@ static void atl1c_get_regs(struct net_device *netdev, memset(p, 0, AT_REGS_LEN); regs->version = 0; - AT_READ_REG(hw, REG_VPD_CAP, p++); AT_READ_REG(hw, REG_PM_CTRL, p++); AT_READ_REG(hw, REG_MAC_HALF_DUPLX_CTRL, p++); AT_READ_REG(hw, REG_TWSI_CTRL, p++); diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h index c22d698..f5c7473 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_hw.h @@ -59,17 +59,6 @@ int atl1c_phy_power_saving(struct atl1c_hw *hw); #define LINK_CTRL_L1_EN 0x02 #define LINK_CTRL_EXT_SYNC 0x80 -#define REG_VPD_CAP 0x6C -#define VPD_CAP_ID_MASK 0xff -#define VPD_CAP_ID_SHIFT 0 -#define VPD_CAP_NEXT_PTR_MASK 0xFF -#define VPD_CAP_NEXT_PTR_SHIFT 8 -#define VPD_CAP_VPD_ADDR_MASK 0x7FFF -#define VPD_CAP_VPD_ADDR_SHIFT 16 -#define VPD_CAP_VPD_FLAG 0x80000000 - -#define REG_VPD_DATA 0x70 - #define REG_PCIE_UC_SEVERITY 0x10C #define PCIE_UC_SERVRITY_TRN 0x00000001 #define PCIE_UC_SERVRITY_DLP 0x00000010