From patchwork Thu Mar 1 16:52:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danny Kukawka X-Patchwork-Id: 144074 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5F00E1007D4 for ; Fri, 2 Mar 2012 03:54:43 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758570Ab2CAQxO (ORCPT ); Thu, 1 Mar 2012 11:53:14 -0500 Received: from wp188.webpack.hosteurope.de ([80.237.132.195]:51646 "EHLO wp188.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758273Ab2CAQxL (ORCPT ); Thu, 1 Mar 2012 11:53:11 -0500 Received: from nat.nue.novell.com ([195.135.221.2] helo=g231.suse.de); authenticated by wp188.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1S39Fa-0008Do-Qq; Thu, 01 Mar 2012 17:53:06 +0100 From: Danny Kukawka To: "David S. Miller" Cc: Danny Kukawka , John Crispin , Joe Perches , Ralf Baechle , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/7] lantiq_etop: use dev_set_mac_address() instead of ltq_etop_set_mac_address() Date: Thu, 1 Mar 2012 17:52:25 +0100 Message-Id: <1330620747-4047-6-git-send-email-danny.kukawka@bisect.de> X-Mailer: git-send-email 1.7.8.3 In-Reply-To: <1330620747-4047-1-git-send-email-danny.kukawka@bisect.de> References: <1330620747-4047-1-git-send-email-danny.kukawka@bisect.de> X-bounce-key: webpack.hosteurope.de; danny.kukawka@bisect.de; 1330620791; 669231a1; Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Use dev_set_mac_address() instead of ltq_etop_set_mac_address() directly to get validation checks for free. Signed-off-by: Danny Kukawka Acked-by: John Crispin --- drivers/net/ethernet/lantiq_etop.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c index 5dc9cbd..2419f51 100644 --- a/drivers/net/ethernet/lantiq_etop.c +++ b/drivers/net/ethernet/lantiq_etop.c @@ -650,11 +650,11 @@ ltq_etop_init(struct net_device *dev) random_mac = true; } - err = ltq_etop_set_mac_address(dev, &mac); + err = dev_set_mac_address(dev, &mac); if (err) goto err_netdev; - /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */ + /* Set addr_assign_type here, dev_set_mac_address would reset it. */ if (random_mac) dev->addr_assign_type |= NET_ADDR_RANDOM;