From patchwork Tue Feb 14 11:10:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 141100 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0D2CD1007D1 for ; Tue, 14 Feb 2012 22:10:32 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760030Ab2BNLK2 (ORCPT ); Tue, 14 Feb 2012 06:10:28 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:39305 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760010Ab2BNLKZ (ORCPT ); Tue, 14 Feb 2012 06:10:25 -0500 Received: by wics10 with SMTP id s10so4069245wic.19 for ; Tue, 14 Feb 2012 03:10:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:subject:from:to:cc:date:content-type:x-mailer :content-transfer-encoding:mime-version; bh=W/53HqFS5eTTVCVpnPQgflLdL8lLVI8Y2XmDGm6k7VE=; b=FrLejX+mFSsXbtNnKhhUXdlDiPozhugtGZigbO/rkSA9j7HlhytoLKhEkFq+gwqwM6 WDXhNy7c6Me/0Ctfj/BL6AzxoDRklJ1lNox3UbA6/DzOJxofj0r8xNbPYqpYcsP3hJbK vXKr0IL064AA0OTpB9kREXPET10D8U0YSKKbo= Received: by 10.180.99.100 with SMTP id ep4mr29991428wib.7.1329217824148; Tue, 14 Feb 2012 03:10:24 -0800 (PST) Received: from [10.150.51.216] (gw0.net.jmsp.net. [212.23.165.14]) by mx.google.com with ESMTPS id m16sm16382484wie.9.2012.02.14.03.10.22 (version=SSLv3 cipher=OTHER); Tue, 14 Feb 2012 03:10:22 -0800 (PST) Message-ID: <1329217821.2336.3.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC> Subject: [RFC] netpoll: netpoll_poll_dev() should access dev->flags From: Eric Dumazet To: Amerigo Wang Cc: netdev , Neil Horman Date: Tue, 14 Feb 2012 12:10:21 +0100 X-Mailer: Evolution 3.2.2- Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org commit 5a698af53f (bond: service netpoll arp queue on master device) use a dubious test : if (dev->priv_flags & IFF_SLAVE) It seems to me IFF_SLAVE is present on dev->flags only ? What am I missing ? Acked-by: Neil Horman --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 4ce473e..3d84fb9 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -205,7 +205,7 @@ static void netpoll_poll_dev(struct net_device *dev) poll_napi(dev); - if (dev->priv_flags & IFF_SLAVE) { + if (dev->flags & IFF_SLAVE) { if (dev->npinfo) { struct net_device *bond_dev = dev->master; struct sk_buff *skb;