From patchwork Mon Nov 21 20:25:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jorge Boncompte [DTI2]" X-Patchwork-Id: 126922 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 94506B7203 for ; Tue, 22 Nov 2011 07:26:40 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756184Ab1KUU0V (ORCPT ); Mon, 21 Nov 2011 15:26:21 -0500 Received: from alcalazamora.dti2.net ([81.24.162.8]:56411 "EHLO alcalazamora.dti2.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754388Ab1KUU0S (ORCPT ); Mon, 21 Nov 2011 15:26:18 -0500 X-MDAV-Processed: alcalazamora.dti2.net, Mon, 21 Nov 2011 21:26:16 +0100 Received: from nikopol.intranet.dti2.net ([81.24.160.13]) (authenticated user jorge@dti2.net) by alcalazamora.dti2.net (alcalazamora.dti2.net [81.24.162.8]) (MDaemon PRO v12.5.0) with ESMTP id md50019764593.msg for ; Mon, 21 Nov 2011 21:26:15 +0100 X-Authenticated-Sender: jorge@dti2.net X-MDRemoteIP: 81.24.160.13 X-Return-Path: prvs=13067620ad=jorge@dti2.net X-Envelope-From: jorge@dti2.net X-MDaemon-Deliver-To: netdev@vger.kernel.org From: "Jorge Boncompte [DTI2]" To: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net Cc: "Jorge Boncompte [DTI2]" Subject: [PATCH 1/5] atm: br2684: Do not move counters backwards Date: Mon, 21 Nov 2011 21:25:54 +0100 Message-Id: <1321907158-27857-2-git-send-email-jorge@dti2.net> X-Mailer: git-send-email 1.7.7.1 In-Reply-To: <1321907158-27857-1-git-send-email-jorge@dti2.net> References: <1321907158-27857-1-git-send-email-jorge@dti2.net> Reply-To: jorge@dti2.net Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: "Jorge Boncompte [DTI2]" This snippet has caused several bugs in the past, and I don't see the point on substracting the skb len from netdev stats. Signed-off-by: Jorge Boncompte [DTI2] --- net/atm/br2684.c | 9 +-------- 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/net/atm/br2684.c b/net/atm/br2684.c index d07223c..81cf33b 100644 --- a/net/atm/br2684.c +++ b/net/atm/br2684.c @@ -557,15 +557,8 @@ static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg) skb_queue_splice_init(rq, &queue); spin_unlock_irqrestore(&rq->lock, flags); - skb_queue_walk_safe(&queue, skb, tmp) { - struct net_device *dev; - + skb_queue_walk_safe(&queue, skb, tmp) br2684_push(atmvcc, skb); - dev = skb->dev; - - dev->stats.rx_bytes -= skb->len; - dev->stats.rx_packets--; - } /* initialize netdev carrier state */ if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)