From patchwork Thu Oct 20 01:34:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gao feng X-Patchwork-Id: 120720 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E7C79B6F7C for ; Thu, 20 Oct 2011 12:33:50 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755865Ab1JTBdq (ORCPT ); Wed, 19 Oct 2011 21:33:46 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:49321 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755839Ab1JTBdp (ORCPT ); Wed, 19 Oct 2011 21:33:45 -0400 Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3]) by song.cn.fujitsu.com (Postfix) with ESMTP id B0A0617012B; Thu, 20 Oct 2011 09:33:41 +0800 (CST) Received: from mailserver.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id p9K1Xfi3008519; Thu, 20 Oct 2011 09:33:41 +0800 Received: from Donkey.fnst.cn.fujitsu.com ([10.167.225.83]) by mailserver.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.1FP4) with ESMTP id 2011102009315260-496260 ; Thu, 20 Oct 2011 09:31:52 +0800 From: Gao feng To: davem@davemloft.net, eric.dumazet@gmail.com Cc: netdev@vger.kernel.org, Gao feng Subject: [PATCH] ipv4: avoid useless call of the function check_peer_pmtu Date: Thu, 20 Oct 2011 09:34:09 +0800 Message-Id: <1319074449-10892-1-git-send-email-gaofeng@cn.fujitsu.com> X-Mailer: git-send-email 1.7.6.1 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-10-20 09:31:52, Serialize by Router on mailserver/fnst(Release 8.5.1FP4|July 25, 2010) at 2011-10-20 09:31:52, Serialize complete at 2011-10-20 09:31:52 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In func ipv4_dst_check,check_peer_pmtu should be called only when peer is updated. So,if the peer is not updated in ip_rt_frag_needed,we can not inc __rt_peer_genid. Signed-off-by: Gao feng Acked-by: Eric Dumazet --- net/ipv4/route.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 075212e..04a14db 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -1568,11 +1568,10 @@ unsigned short ip_rt_frag_needed(struct net *net, const struct iphdr *iph, est_mtu = mtu; peer->pmtu_learned = mtu; peer->pmtu_expires = pmtu_expires; + atomic_inc(&__rt_peer_genid); } inet_putpeer(peer); - - atomic_inc(&__rt_peer_genid); } return est_mtu ? : new_mtu; }