From patchwork Sun Sep 18 11:54:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 115230 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4FB551007D1 for ; Sun, 18 Sep 2011 21:52:34 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752040Ab1IRLw2 (ORCPT ); Sun, 18 Sep 2011 07:52:28 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:48130 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573Ab1IRLw1 (ORCPT ); Sun, 18 Sep 2011 07:52:27 -0400 Received: by mail-pz0-f42.google.com with SMTP id 1so7732480pzk.1 for ; Sun, 18 Sep 2011 04:52:27 -0700 (PDT) Received: by 10.68.28.199 with SMTP id d7mr2418949pbh.142.1316346747255; Sun, 18 Sep 2011 04:52:27 -0700 (PDT) Received: from localhost.localdomain ([180.106.36.88]) by mx.google.com with ESMTPS id 4sm2053371pbk.5.2011.09.18.04.52.12 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Sep 2011 04:52:26 -0700 (PDT) From: Shawn Guo To: netdev@vger.kernel.org Cc: "David S. Miller" , linux-arm-kernel@lists.infradead.org, patches@linaro.org, Shawn Guo Subject: [PATCH 1/4] net/fec: change phy-reset-gpio request warning to debug message Date: Sun, 18 Sep 2011 19:54:09 +0800 Message-Id: <1316346852-17090-2-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1316346852-17090-1-git-send-email-shawn.guo@linaro.org> References: <1316346852-17090-1-git-send-email-shawn.guo@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org FEC can work without a phy reset on some platforms, which means not very platform necessarily have a phy-reset gpio encoded in device tree. So it makes more sense to have the phy-reset-gpio request failure as a debug message rather than a warning. Signed-off-by: Shawn Guo --- drivers/net/fec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/fec.c b/drivers/net/fec.c index e8266cc..6a638e9 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c @@ -1422,7 +1422,7 @@ static int __devinit fec_reset_phy(struct platform_device *pdev) phy_reset = of_get_named_gpio(np, "phy-reset-gpios", 0); err = gpio_request_one(phy_reset, GPIOF_OUT_INIT_LOW, "phy-reset"); if (err) { - pr_warn("FEC: failed to get gpio phy-reset: %d\n", err); + pr_debug("FEC: failed to get gpio phy-reset: %d\n", err); return err; } msleep(1);