From patchwork Wed Jul 27 09:47:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Eckelmann X-Patchwork-Id: 107012 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D7746B6F68 for ; Wed, 27 Jul 2011 19:48:04 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753774Ab1G0Jr7 (ORCPT ); Wed, 27 Jul 2011 05:47:59 -0400 Received: from narfation.org ([79.140.41.39]:39451 "EHLO v3-1039.vlinux.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752252Ab1G0Jr6 (ORCPT ); Wed, 27 Jul 2011 05:47:58 -0400 Received: from sven-desktop.home.narfation.org (bathseba.informatik.tu-chemnitz.de [134.109.192.185]) by v3-1039.vlinux.de (Postfix) with ESMTPSA id 08DD894124; Wed, 27 Jul 2011 11:48:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=narfation.org; s=mail; t=1311760127; bh=BOD43dWDsubGEyJfYsyIZ6kFC+gwbyLVA/ADR0cCrO4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=ordgdaI+gi/Lk/ykF5QQJZ7lQTJo485rREJ58T6lKaFjspcmY48W/56/SeGr29vuP 6WaMaTUQHJKCtqkNHUMw1gLUuLDHZ4AVezktNUDQxSHAyU/xz83FwlPHIVntJs4Yv3 fN2g7IsUwhGZODfhX1J4CR9qYHhSderWnnGC/duw= From: Sven Eckelmann To: linux-arch@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Sven Eckelmann , Neil Horman , netdev@vger.kernel.org Subject: [PATCHv4 10/11] drop_monitor: Use *_dec_not_zero instead of *_add_unless Date: Wed, 27 Jul 2011 11:47:49 +0200 Message-Id: <1311760070-21532-10-git-send-email-sven@narfation.org> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1311760070-21532-1-git-send-email-sven@narfation.org> References: <1311760070-21532-1-git-send-email-sven@narfation.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org atomic_dec_not_zero is defined for each architecture through to provide the functionality of atomic_add_unless(x, -1, 0). Signed-off-by: Sven Eckelmann Cc: Neil Horman Cc: netdev@vger.kernel.org Acked-by: Neil Horman --- net/core/drop_monitor.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/core/drop_monitor.c b/net/core/drop_monitor.c index 7f36b38..ef4a05d 100644 --- a/net/core/drop_monitor.c +++ b/net/core/drop_monitor.c @@ -137,7 +137,7 @@ static void trace_drop_common(struct sk_buff *skb, void *location) struct per_cpu_dm_data *data = &__get_cpu_var(dm_cpu_data); - if (!atomic_add_unless(&data->dm_hit_count, -1, 0)) { + if (!atomic_dec_not_zero(&data->dm_hit_count)) { /* * we're already at zero, discard this hit */