From patchwork Wed Jun 15 07:58:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Changli Gao X-Patchwork-Id: 100491 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3896DB6F92 for ; Wed, 15 Jun 2011 17:59:40 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248Ab1FOH7e (ORCPT ); Wed, 15 Jun 2011 03:59:34 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:56604 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319Ab1FOH7d (ORCPT ); Wed, 15 Jun 2011 03:59:33 -0400 Received: by pvg12 with SMTP id 12so101030pvg.19 for ; Wed, 15 Jun 2011 00:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:cc:subject:date:message-id:x-mailer; bh=adjEsh8vsdPf/ga7CCa5iUU2NFuWozFRgwj30vAWeP0=; b=CzHBw+gOBQs1hi4SAQLQnNAr/I46+ECdu2lHEU0/QSpka5yXeXuc7vA+3uyKX5Nw3N GrkocglnhnqupqRAaZo7JwjTz0TpxBQ+94QPyOcgrNPWbpoVyXLEm24UkzYsauZH3t9/ T3/FwjsL07XU+rPsOuawJ2kNrIWeTXDbt/ziQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=Mc/ERnQZ87g9Tzoqzo0A6Mrg/NADoDQ5w8+2aVw0cvXbV97nbV5APrAX2K4fVR6bR2 BUh1u58890hwUfQEx3GicvoKwjUTTVNKfInzXLufEctIyIXYV/fllmr4+6ufGQUdlJlA Z6SA8S6IuF+qZCLC7cMnDM/TXyqdD0tek2RTg= Received: by 10.68.31.130 with SMTP id a2mr83979pbi.278.1308124772562; Wed, 15 Jun 2011 00:59:32 -0700 (PDT) Received: from localhost.localdomain ([221.239.34.230]) by mx.google.com with ESMTPS id p5sm141095pbd.12.2011.06.15.00.59.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 15 Jun 2011 00:59:30 -0700 (PDT) From: Changli Gao To: "David S. Miller" Cc: Paul Mackerras , linux-ppp@vger.kernel.org, netdev@vger.kernel.org, Changli Gao Subject: [PATCH] ppp: use PPP_TRANS instead of the magic number 0x20 Date: Wed, 15 Jun 2011 15:58:13 +0800 Message-Id: <1308124693-6600-1-git-send-email-xiaosuo@gmail.com> X-Mailer: git-send-email 1.7.3.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Changli Gao --- drivers/net/ppp_async.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c index 6436ba9..c6ba643 100644 --- a/drivers/net/ppp_async.c +++ b/drivers/net/ppp_async.c @@ -524,7 +524,7 @@ static void ppp_async_process(unsigned long arg) #define PUT_BYTE(ap, buf, c, islcp) do { \ if ((islcp && c < 0x20) || (ap->xaccm[c >> 5] & (1 << (c & 0x1f)))) {\ *buf++ = PPP_ESCAPE; \ - *buf++ = c ^ 0x20; \ + *buf++ = c ^ PPP_TRANS; \ } else \ *buf++ = c; \ } while (0) @@ -897,7 +897,7 @@ ppp_async_input(struct asyncppp *ap, const unsigned char *buf, sp = skb_put(skb, n); memcpy(sp, buf, n); if (ap->state & SC_ESCAPE) { - sp[0] ^= 0x20; + sp[0] ^= PPP_TRANS; ap->state &= ~SC_ESCAPE; } }